Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Split generic and specific code #215

Merged
merged 7 commits into from
Apr 23, 2021
Merged

Split generic and specific code #215

merged 7 commits into from
Apr 23, 2021
+102 −95

Conversation

neomilium
Copy link
Contributor

This PR offers the first step to turn msync into a more generic tool by splitting PuppetModule class into SourceCode and PuppetModule classes.

PS: This PR is a part of #206.

ekohl
ekohl reviewed Apr 22, 2021
View reviewed changes
Copy link
Member

@ekohl ekohl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall this makes sense. I like how you're starting to separate the workflow from low level implementation.

@neomilium neomilium force-pushed the split_generic_n_specific_code branch from 86e291c to 797360e Compare April 23, 2021 07:13
@neomilium neomilium force-pushed the split_generic_n_specific_code branch from 797360e to 38efd68 Compare April 23, 2021 07:13
@neomilium neomilium mentioned this pull request Apr 23, 2021
Open
@neomilium
Copy link
Contributor Author

@ekohl This PR is ready to merge IMHO, could you have a look? Thanks

ekohl
ekohl approved these changes Apr 23, 2021
View reviewed changes
Copy link
Member

@ekohl ekohl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Small nit, but otherwise 👍

@neomilium neomilium force-pushed the split_generic_n_specific_code branch from 38efd68 to 4e9f330 Compare April 23, 2021 09:32
@neomilium
Copy link
Contributor Author

@ekohl Thats the moment to push the big green button ;-)

ekohl
ekohl approved these changes Apr 23, 2021
View reviewed changes
Copy link
Member

@ekohl ekohl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like I don't have to highlight every case of a pattern. You understand that. I've seen it different in some reviews :)

@ekohl ekohl merged commit e22daf8 into voxpupuli:master Apr 23, 2021
@neomilium neomilium deleted the split_generic_n_specific_code branch April 23, 2021 09:45
@neomilium neomilium mentioned this pull request Oct 18, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ekohl ekohl ekohl approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@neomilium @ekohl