Always download the common test suite before running tests #387
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@RST-J Could I please get a quick review of this? It's a change to the test suite rather than user-facing code. |
|
Ok this isn't fixing an issue on travis as I first thought. It seems that by default travis performs a git submodule update after checkout, which is what we're doing here. However, it would be helpful if we did this automatically for contributors too |
In voxpupuli#377 I made it possible to run the tests without having internet access. But it seems that in the process I also disabled the code that downloads the common test suite when you first check out the codebase. This changes the behaviour so that if you run the test suite and you have internet access the common test suite is automatically downloaded. If you don't have internet access it continues without it. To update the common test suite to the latest version, you now need to run the tests with the `UPDATE_TEST_SUITE` env var set.
iainbeeston
force-pushed
the
include-common-test-suite
branch
from
8b434c9 to
d98bd02
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In #377 I made it possible to run the tests without having internet
access. But it seems that in the process I also disabled the code that
downloads the common test suite when you first check out the
codebase.
This changes the behaviour so that if you run the test suite and you
have internet access the common test suite is automatically
downloaded. If you don't have internet access it continues without
it. To update the common test suite to the latest version, you now
need to run the tests with the
UPDATE_TEST_SUITEenv var set.