Fix validator when the specified fragment includes array #217
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Jan 16, 2016
|
The only failing build is for rbx due to a segmentation fault after the (passing) tests. Is it possible to get this implemented? |
|
I need to take a closer look to make sure I understand the implications of this change, and whether it really fixes #265 . I'll try to get this merged and released asap |
|
thx! :D |
|
Tried @take -san fork and it worked for me. |
|
@iainbeeston Can we get this resolved? The issue still exists. |
|
I'm planning on adding some more tests and getting this merged after #382. Unfortunately the bug is important enough, and been around for long enough, that I'd rather get the fix merged and worry about the larger picture later |
iainbeeston
added a commit
to iainbeeston/json-schema
that referenced
this pull request
Jul 5, 2017
|
I've merged this manually in c12f600 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.