Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Increase test coverage #246

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Increase test coverage #246

wants to merge 1 commit into from

Conversation

bastelfreak
Copy link
Member

This adds tests for operatingsystemrelease / operatingsystemmajrelease

@bastelfreak bastelfreak self-assigned this Apr 21, 2022
@bastelfreak
Copy link
Member Author

The code in question is: https://github.com/voxpupuli/rspec-puppet-facts/blob/0df5a5d82b48f7bc87016e46b247b69a6f5c3302/lib/rspec-puppet-facts.rb#L152-L165

@ekohl
Copy link
Member

ekohl commented Apr 21, 2022

I wonder if we should make rspec-puppet-facts understand a missing release. If facter does really return null for these we could synthesize it to rolling or simplify it to os-arch instead of os-release-arch.

@bastelfreak bastelfreak reopened this Nov 14, 2022
@yakatz
Copy link
Contributor

yakatz commented Mar 19, 2024

Obsoleted by #266?

@bastelfreak
Increase test coverage
2128b6b 
This adds tests for operatingsystemrelease / operatingsystemmajrelease
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@bastelfreak bastelfreak

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@bastelfreak @ekohl @yakatz