-
-
Notifications
You must be signed in to change notification settings - Fork 45
docker setup + now.json example to deploy to zeit.co #87
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Would love to have documentation for how to deploy this to other targets than Heroku 👍 |
added some basic docs to readme in this branch. note - for this to work the btw. I used npm install/npm start in the Dockerfile - seem to work even though yarn referenced elsewhere. |
I'll give this a closer look asap |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A quick review with some thoughts – looks good! Great to get a PR with this 🙂
lib/config.js
Outdated
token: env[prefix + 'GITHUB_TOKEN'] | ||
user: env[prefix + 'GITHUB_USER'], | ||
token: env[prefix + 'GITHUB_TOKEN'], | ||
branch: env[prefix + 'GITHUB_BRANCH'] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Merged in the other PR 🙂
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
removed/rebased.
I'll look into fixing the build failure |
I thought the build errors were in |
The console log broke things?? |
It didn’t pass the coding style check ;)
Will you clean up this PR and I’ll merge it or should I pick the good parts
out of it and commit?
ons 2 jan. 2019 kl. 21:52 skrev Max Rydahl Andersen <
[email protected]>:
… The console log broke things??
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
<#87 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AACGmYEK6QYBEi6Jt20KAW-9vKKRjs8Oks5u_Rv_gaJpZM4ZmFEA>
.
|
* Quote env variable value * Add configuration
There are no publihsed docker image thus having docker-compose.yml don't make sense at this moment.
Move to use yarn in docker and exclude package-lock.json from dockerfile.
fixed/removed what I could find and pushed. feel free to take it or pick and choose as you need it. |
I never managed to get it deploying to heroku as it kept going to sleep.
Had better luck with zeit.co based on work done by https://github.com/marians/webpage-micropub-to-github
This is a initial PR just showing the work - if interest I can add some basic docs in the readme.