Skip to content

Conversation

maxandersen
Copy link
Contributor

I never managed to get it deploying to heroku as it kept going to sleep.
Had better luck with zeit.co based on work done by https://github.com/marians/webpage-micropub-to-github

This is a initial PR just showing the work - if interest I can add some basic docs in the readme.

@voxpelli
Copy link
Owner

voxpelli commented Jan 2, 2019

Would love to have documentation for how to deploy this to other targets than Heroku 👍

@maxandersen
Copy link
Contributor Author

added some basic docs to readme in this branch.

note - for this to work the now.json and Dockerfile in this PR need to be added to the repo

btw. I used npm install/npm start in the Dockerfile - seem to work even though yarn referenced elsewhere.

@voxpelli
Copy link
Owner

voxpelli commented Jan 2, 2019

npm install works, but it ignores the yarn lock file so it may install newer packages that hasn't been tested together

I'll give this a closer look asap

Copy link
Owner

@voxpelli voxpelli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A quick review with some thoughts – looks good! Great to get a PR with this 🙂

lib/config.js Outdated
token: env[prefix + 'GITHUB_TOKEN']
user: env[prefix + 'GITHUB_USER'],
token: env[prefix + 'GITHUB_TOKEN'],
branch: env[prefix + 'GITHUB_BRANCH']
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Merged in the other PR 🙂

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

removed/rebased.

@voxpelli
Copy link
Owner

voxpelli commented Jan 2, 2019

I'll look into fixing the build failure

@voxpelli
Copy link
Owner

voxpelli commented Jan 2, 2019

I thought the build errors were in master, but on closer look it's actually the few small changes to the js code you made 😊

@maxandersen
Copy link
Contributor Author

The console log broke things??

@voxpelli
Copy link
Owner

voxpelli commented Jan 2, 2019 via email

marians and others added 12 commits January 4, 2019 08:35
* Quote env variable value
* Add configuration
There are no publihsed docker image thus having docker-compose.yml
don't make sense at this moment.
Move to use yarn in docker and exclude package-lock.json from dockerfile.
@maxandersen
Copy link
Contributor Author

fixed/removed what I could find and pushed.

feel free to take it or pick and choose as you need it.

Base automatically changed from master to main March 3, 2021 21:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants