-
Notifications
You must be signed in to change notification settings - Fork 605
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Model evaluation subsets backend #5512
base: develop
Are you sure you want to change the base?
Conversation
Important Review skippedDraft detected. Please check the settings in the CodeRabbit UI or the You can disable this status message by setting the Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
Documentation and Community
|
ea2241e
to
a1e1431
Compare
@@ -504,6 +505,24 @@ def load_view(self, ctx): | |||
field = view_options.get("field", None) | |||
missing = ctx.panel.get_state("missing", "(none)") | |||
|
|||
# Restrict to subset, if applicable | |||
subset_name = view_state.get("subset_name", None) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This should wire up view callbacks for the ME panel, assuming that:
- A
subset_name
parameter is set that encodes the name of the subset (bar) that the user clicked on - A
subsets
dict is available in panel state that encodes the user's current subsets definition, using the structure described in theSubsets specification
section of the PR description
Change log
Adds support for computing metrics for subsets of a full set of evaluation results via a new
use_subset()
method.Example usage
Full results:
Sunny samples:
Small objects:
Subsets specification
Subset field
Subset expressions
Subsets analysis