Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

teams -> enterprise #5508

Open
wants to merge 2 commits into
base: develop
Choose a base branch
from
Open

teams -> enterprise #5508

wants to merge 2 commits into from
+9 −168

Conversation

sashankaryal
Copy link
Contributor

@sashankaryal sashankaryal commented Feb 21, 2025 •
edited by coderabbitai bot
Loading

Summary by CodeRabbit

  • Chores
    • Removed the team information submission form from the interface.
  • New Features
    • Updated upgrade prompts in both the model evaluation and embeddings sections to encourage upgrading to FiftyOne Enterprise.
  • Documentation
    • Updated the README to reflect the renaming from FiftyOne Teams to FiftyOne Enterprise, ensuring consistency in terminology throughout the document.

These changes streamline the user experience and provide a consistent, updated message reflecting our current product branding.

@coderabbitai coderabbitai
Copy link
Contributor

coderabbitai bot commented Feb 21, 2025 •
edited
Loading

Walkthrough

This pull request removes the entire Teams component that handled team information submission. It also updates two instances of the promotional message in the PanelCTA component—one in NativeModelEvaluationView and one in EmbeddingsCTA—by replacing "FiftyOne Teams" with "FiftyOne Enterprise." Additionally, an inline comment in useComputeVisualization.ts is updated to clarify the environment context. No changes were made to the underlying business logic or control flow.

Changes

File(s) Change Summary
app/packages/components/.../Teams/Teams.tsx Removed the entire Teams component responsible for handling team information submission.
app/packages/core/.../NativeModelEvaluationView/index.tsx
app/packages/embeddings/.../EmbeddingsCTA.tsx		 Updated demoLabel in the PanelCTA component: changed "FiftyOne Teams" to "FiftyOne Enterprise."
app/packages/embeddings/src/useComputeVisualization.ts Updated the comment for the IS_OSS constant to reflect the "fiftyone-enterprise" environment.
README.md Updated references from "FiftyOne Teams" to "FiftyOne Enterprise," including link texts and HTML identifiers.

Suggested labels

documentation

Suggested reviewers

  • brimoor
  • imanjra
  • findtopher

Poem

I'm a rabbit with hops so spry,
Celebrating changes that catch the eye.
Teams are gone, enterprise stands tall,
Upgrading labels with a cheerful call.
With every line and every tweak,
I nibble on code and play hide-and-seek!
🥕🐇

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR. (Beta)
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@sashankaryal sashankaryal self-assigned this Feb 21, 2025
@sashankaryal sashankaryal requested a review from jleven February 21, 2025 18:07
coderabbitai[bot]
coderabbitai bot reviewed Feb 21, 2025
View reviewed changes
Copy link
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 0

🧹 Nitpick comments (1)
README.md (1)

482-482: Accessibility Improvement: Add Alternate Text for Image

The header image for the "FiftyOne Enterprise" section lacks an alt attribute. For improved accessibility and to satisfy markdown linting (MD045), consider adding an alt attribute such as alt="FiftyOne Enterprise logo". For example:

-<img src="https://user-images.githubusercontent.com/25985824/106288517-2422e000-6216-11eb-871d-26ad2e7b1e59.png" height="20px">
+<img src="https://user-images.githubusercontent.com/25985824/106288517-2422e000-6216-11eb-871d-26ad2e7b1e59.png" alt="FiftyOne Enterprise logo" height="20px">
🧰 Tools
🪛 markdownlint-cli2 (0.17.2)

482-482: Images should have alternate text (alt text)
null

(MD045, no-alt-text)

📜 Review details

Configuration used: .coderabbit.yaml
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between d01fbd8 and 6003384.

📒 Files selected for processing (1)
  • README.md (3 hunks)
🧰 Additional context used
🪛 markdownlint-cli2 (0.17.2)
README.md

482-482: Images should have alternate text (alt text)
null

(MD045, no-alt-text)

⏰ Context from checks skipped due to timeout of 90000ms (7)
  • GitHub Check: test / test-python (ubuntu-latest-m, 3.11)
  • GitHub Check: test / test-python (ubuntu-latest-m, 3.10)
  • GitHub Check: test / test-python (ubuntu-latest-m, 3.9)
  • GitHub Check: test / test-app
  • GitHub Check: e2e / test-e2e
  • GitHub Check: build / build
  • GitHub Check: build
🔇 Additional comments (4)
README.md (4)

42-44: Branding Update in Promotional Message

The promotional message has been updated to "FiftyOne Enterprise 🚀" from the previous reference. Please double-check that this change is intentional and consistent with the new "Enterprise" branding.

459-461: Consistent Update in Additional Resources Table

The additional resources table now lists "FiftyOne Enterprise" as the first entry. This update looks consistent with the overall branding change. Please verify that any other related references have been updated similarly.

480-480: HTML Element ID Update

The HTML <div> has been updated from id='fiftyone-teams' to id='fiftyone-enterprise'. Ensure that any CSS, JavaScript, or other selectors previously referencing the old identifier are updated accordingly.

486-486: Link Text Consistency

The updated link in the header now reads "FiftyOne Enterprise". This change is consistent with the overall update. Please verify that the URL and link styling align with your documentation standards.

kaixi-wang
kaixi-wang reviewed Feb 24, 2025
View reviewed changes
app/packages/embeddings/src/useComputeVisualization.ts
@@ -2,7 +2,7 @@ import { useFirstExistingUri, usePanelEvent } from "@fiftyone/operators";
import { usePanelId } from "@fiftyone/spaces";
import { useCallback } from "react";

const IS_OSS = true; // false in fiftyone-teams
const IS_OSS = true; // false in fiftyone-enterprise
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this should still be teams since we aren't renaming the repos?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kaixi-wang kaixi-wang kaixi-wang left review comments

@coderabbitai coderabbitai[bot] coderabbitai[bot] left review comments

@jleven jleven Awaiting requested review from jleven

At least 1 approving review is required to merge this pull request.

Assignees

@sashankaryal sashankaryal

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sashankaryal @kaixi-wang