-
Notifications
You must be signed in to change notification settings - Fork 605
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[draft] add support for arbitrary media types #5506
base: develop
Are you sure you want to change the base?
Conversation
Important Review skippedIgnore keyword(s) in the title. ⛔ Ignored keywords (3)
Please check the settings in the CodeRabbit UI or the You can disable this status message by setting the Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
Documentation and Community
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👑
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we please not merge this into develop
until we're sure the SDK is fully wired up to support custom media types in a way we're comfortable with? And we have documentation for it, etc.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@tom-vx51 I was playing with this tonight and noticed that the 3D visualizer is not appearing as expected on this branch, both for "flat" 3D datasets and grouped datasets that contain 3D slices:
import fiftyone as fo
import fiftyone.zoo as foz
session = fo.launch_app()
session.dataset = foz.load_zoo_dataset("quickstart-3d")
session.dataset = foz.load_zoo_dataset("quickstart-groups")
Can you take a look?
What changes are proposed in this pull request?
Currently, all datasets must have media types that are natively supported by FiftyOne (image, video, point-cloud, 3d), or groups of such media types. This PR adds support to the SDK and app for arbitrary media types.
Samples with non-native media types are rendered with relevant metadata in the grid.
How is this patch tested? If it is not, please explain why.
unit tests, local app
Release Notes
Is this a user-facing change that should be mentioned in the release notes?
notes for FiftyOne users.
(Details in 1-2 sentences. You can just refer to another PR with a description
if this PR is part of a larger change.)
Add support for creating samples with arbitrary
media_type
.What areas of FiftyOne does this PR affect?
fiftyone
Python library changes