Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use category as xaxis type for per-class perf charts #5504

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from

Conversation

imanjra
Copy link
Contributor

@imanjra imanjra commented Feb 20, 2025

What changes are proposed in this pull request?

use category as xaxis type for per-class perf charts to avoid binning by plotly.js

How is this patch tested? If it is not, please explain why.

Using the model evaluation panel with numerical class labels

Release Notes

Is this a user-facing change that should be mentioned in the release notes?

  • No. You can skip the rest of this section.
  • Yes. Give a description of this change to be included in the release
    notes for FiftyOne users.

use category as xaxis type for per-class perf charts

What areas of FiftyOne does this PR affect?

  • App: FiftyOne application changes
  • Build: Build and test infrastructure changes
  • Core: Core fiftyone Python library changes
  • Documentation: FiftyOne documentation changes
  • Other

Summary by CodeRabbit

  • New Features
    • Enhanced chart visuals by configuring the evaluation plots and confusion matrix to interpret x-axis values as categorical, providing clearer, more intuitive displays.

@imanjra imanjra requested a review from a team February 20, 2025 18:23
Copy link
Contributor

coderabbitai bot commented Feb 20, 2025

Walkthrough

This pull request updates the layout configuration for the EvaluationPlot component within the Evaluation function. When classMode is set to "chart", the x-axis is now explicitly defined as categorical. The same layout setting is also applied to the confusion matrix plot, ensuring that both visualizations correctly interpret the x-axis data as categorical. No other functional or logical changes have been made.

Changes

File Change Summary
app/.../Evaluation.tsx Added layout configuration to EvaluationPlot for categorical x-axis in both chart and confusion matrix views.

Possibly related PRs

Suggested reviewers

  • ritch
  • brimoor

Poem

I'm a coding rabbit, hopping in delight,
Tweaking layouts to set each plot just right.
The x-axis now prances in a categorical beat,
Making metrics and matrices visually neat.
With a joyful hop and a clever code tweak,
I celebrate improvements that make our charts unique!


📜 Recent review details

Configuration used: .coderabbit.yaml
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 931fee1 and 109802e.

📒 Files selected for processing (1)
  • app/packages/core/src/plugins/SchemaIO/components/NativeModelEvaluationView/Evaluation.tsx (1 hunks)
🧰 Additional context used
📓 Path-based instructions (1)
`**/*.{ts,tsx}`: Review the Typescript and React code for co...

**/*.{ts,tsx}: Review the Typescript and React code for conformity with best practices in React, Recoil, Graphql, and Typescript. Highlight any deviations.

  • app/packages/core/src/plugins/SchemaIO/components/NativeModelEvaluationView/Evaluation.tsx
⏰ Context from checks skipped due to timeout of 90000ms (6)
  • GitHub Check: test / test-python (ubuntu-latest-m, 3.10)
  • GitHub Check: test / test-app
  • GitHub Check: e2e / test-e2e
  • GitHub Check: build / build
  • GitHub Check: lint / eslint
  • GitHub Check: build / changes
🔇 Additional comments (3)
app/packages/core/src/plugins/SchemaIO/components/NativeModelEvaluationView/Evaluation.tsx (3)

1135-1137: LGTM! The categorical x-axis type will improve data visualization.

The addition of type: "category" for the x-axis ensures that the plotly.js library treats class labels as categorical data rather than attempting numerical binning. This change aligns perfectly with the PR objective and will enhance the clarity of per-class performance charts.


1278-1287: LGTM! Consistent use of categorical axes in confusion matrix.

The confusion matrix plot also uses categorical type for both x and y axes, which maintains consistency in how class labels are displayed across different visualizations.


1330-1339: LGTM! Consistent configuration in comparison view.

The same categorical axis configuration is correctly applied to the comparison confusion matrix plot, ensuring consistent behavior across both the main and comparison views.


Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR. (Beta)
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants