Python 3 conversion #27
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jboes
commented
Jul 3, 2018
|
|
||
| if self.convergence is None: | ||
| self.conv_thr = 1e-6/rydberg | ||
| self.conv_thr = 1e-6 / Rydberg |
There was a problem hiding this comment.
Constraints removed in favor of ASE values (the same to 5th decimal place)
| J = Jlist[i], | ||
| U_alpha = U_alphalist[i]) | ||
|
|
||
| self.specdict[s] = utils.SpecObject( |
There was a problem hiding this comment.
Camel Case for SpecObject python class naming convention.
|
|
||
| def read_2d_grid(self, stream, log): |
There was a problem hiding this comment.
This function isn't called at all. I removed it, but can add it back if necessary.
| x = stream.readline() | ||
| data = [] | ||
| ntotal = np.prod(n) | ||
| while len(data) < ntotal: |
There was a problem hiding this comment.
Change from np.fromfile to loop which accomplishes the same effect. The bytes stdout from the subprocess command was not being handled correctly.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Significant changes for Python3 compatibility:
aggressive autopep8 and yapf formatting changes for readability.