Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds .html.erb to erb language extensions for toggleTags command #7

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

kjleitz
Copy link

@kjleitz kjleitz commented Oct 21, 2018

Previously the ctrl+shift+` keybinding did not work out-of-the-box in *.html.erb files (the default extension for erb views in Rails). This PR adds that file extension to the erb language definition in package.json.

This may have been the source of #5

@seanharmer
Copy link

Any chance of getting this merged please?

@kjleitz kjleitz requested a review from vortizhe February 21, 2020 17:45
@jonathansimmons
Copy link

@vortizhe This really is a necessity for this extension. Please merge.

@kirillplatonov
Copy link

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants