Skip to content

Report column size stat for primitive columns in df #7636

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
AdamGS wants to merge 2 commits into
base: develop
Choose a base branch
from
Draft

Report column size stat for primitive columns in df #7636

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
afe48ee
Report column size stat for primitive columns in df
AdamGS Apr 25, 2026
ca6942f
checked mul
AdamGS Apr 25, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
19 changes: 12 additions & 7 deletions vortex-datafusion/src/persistent/format.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -511,6 +511,9 @@ impl FileFormat for VortexFormat {
};

let mut column_statistics = Vec::with_capacity(table_schema.fields().len());
let num_rows = usize::try_from(row_count)
.map_err(|_| vortex_err!("Row count overflow"))
.vortex_expect("Row count overflow");

for field in table_schema.fields().iter() {
// If the column does not exist, continue. This can happen if the schema has evolved
Expand All @@ -523,8 +526,14 @@ impl FileFormat for VortexFormat {
let (stats_set, stats_dtype) = file_stats.get(col_idx);

// Update the total size in bytes.
let column_size =
stats_set.get_as::<usize>(Stat::UncompressedSizeInBytes, &PType::U64.into());

let column_size = stats_set
.get_as::<usize>(Stat::UncompressedSizeInBytes, &PType::U64.into())
.or_else(|| {
field.data_type().primitive_width().and_then(|width| {
width.checked_mul(num_rows).map(stats::Precision::Exact)
})
});

let target_dtype = DType::from_arrow(field.as_ref());
let min = scalar_stat_to_df(
Expand Down Expand Up @@ -562,11 +571,7 @@ impl FileFormat for VortexFormat {
.fold(Precision::Exact(0), |acc, cs| acc.add(&cs.byte_size));

Ok(Statistics {
num_rows: Precision::Exact(
usize::try_from(row_count)
.map_err(|_| vortex_err!("Row count overflow"))
.vortex_expect("Row count overflow"),
),
num_rows: Precision::Exact(num_rows),
total_byte_size,
column_statistics,
})
Expand Down
Loading