Open
Conversation
Signed-off-by: Nicholas Gates <nick@nickgates.com>
Signed-off-by: Nicholas Gates <nick@nickgates.com>
robert3005
previously approved these changes
Apr 15, 2026
Signed-off-by: Robert Kruszewski <github@robertk.io>
robert3005
dismissed
their stale review
The benchmark numbers are not for this benchmark
Contributor
|
I pushed a commit to fix the build. Benchmarks need to be trimmed, even on my machine they take ~10ms which is way too slow for microbenchmark imho. The improvement here is more modest 35-50% |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
extend_from_array_non_zctl_overlapping (1000, 8)1.413 ms80.71 us17.5xextend_from_array_non_zctl_overlapping (1000, 32)2.586 ms83.67 us30.9xextend_from_array_non_zctl_overlapping (10000, 8)9.708 ms560.3 us17.3xextend_from_array_zctl (1000, 8)1.116 ms14.31 us78.0xextend_from_array_zctl (1000, 64)5.511 ms38.68 us142.5xextend_from_array_zctl (10000, 8)11.01 ms108.4 us101.6xBefore = commit
d72bf9b93(pre-fix), After = commitc4ad4e2ad(the ListViewBuilder scalar-at removal fix).