Propagate min/max/string length statistics to duckdb#7416
Open
Propagate min/max/string length statistics to duckdb#7416
Conversation
myrrc
changed the title
myrrc
force-pushed
the
myrrc/duckdb-column-stats
branch
from
5848867 to
c4a56e6
Compare
myrrc
force-pushed
the
myrrc/duckdb-column-stats
branch
from
c4a56e6 to
69e130d
Compare
myrrc
added
action/benchmark
github-actions
bot
removed
action/benchmark-sql
myrrc
added
action/benchmark
github-actions
bot
removed
action/benchmark-sql
myrrc
added
action/benchmark
github-actions
bot
removed
action/benchmark
myrrc
added
action/benchmark
github-actions
bot
removed
action/benchmark
github-actions
bot
removed
the
action/benchmark
Contributor
Polar Signals Profiling ResultsLatest Run
Previous Runs (2)
Powered by Polar Signals Cloud |
Contributor
Benchmarks: TPC-DS SF=1 on NVMEVerdict: No clear signal (low confidence) datafusion / vortex-file-compressed (0.980x ➖, 1↑ 0↓)
datafusion / vortex-compact (0.986x ➖, 0↑ 0↓)
datafusion / parquet (0.974x ➖, 1↑ 0↓)
duckdb / vortex-file-compressed (1.046x ➖, 11↑ 32↓)
duckdb / vortex-compact (1.129x ❌, 10↑ 52↓)
duckdb / parquet (0.991x ➖, 1↑ 1↓)
duckdb / duckdb (0.999x ➖, 1↑ 2↓)
Full attributed analysis
|
Contributor
File Sizes: TPC-DS SF=1 on NVMENo file size changes detected. |
Contributor
Benchmarks: Clickbench on NVMEVerdict: No clear signal (low confidence) datafusion / vortex-file-compressed (0.989x ➖, 0↑ 0↓)
datafusion / parquet (0.996x ➖, 0↑ 0↓)
duckdb / vortex-file-compressed (1.250x ❌, 4↑ 25↓)
duckdb / parquet (0.996x ➖, 0↑ 0↓)
duckdb / duckdb (1.025x ➖, 0↑ 3↓)
Full attributed analysis
|
Contributor
Benchmarks: FineWeb S3Verdict: No clear signal (environment too noisy confidence) datafusion / vortex-file-compressed (1.058x ➖, 0↑ 1↓)
datafusion / vortex-compact (0.985x ➖, 0↑ 0↓)
datafusion / parquet (1.027x ➖, 0↑ 0↓)
duckdb / vortex-file-compressed (1.062x ➖, 0↑ 0↓)
duckdb / vortex-compact (1.064x ➖, 0↑ 1↓)
duckdb / parquet (1.011x ➖, 0↑ 0↓)
Full attributed analysis
|
Contributor
🚨🚨🚨❌❌❌ SQL BENCHMARK FAILED ❌❌❌🚨🚨🚨Benchmark |
myrrc
force-pushed
the
myrrc/duckdb-column-stats
branch
2 times, most recently
from
39c09ca to
f79f5b0
Compare
myrrc
force-pushed
the
myrrc/duckdb-column-stats
branch
2 times, most recently
from
e2e1bbe to
46c5eaf
Compare
myrrc
added
action/benchmark
github-actions
bot
removed
action/benchmark-sql
Contributor
File Sizes: Statistical and Population GeneticsNo file size changes detected. |
Contributor
File Sizes: Clickbench on NVMENo baseline file sizes found for base commit. |
Contributor
Benchmarks: Random AccessVortex (geomean): 0.816x ✅ unknown / unknown (0.907x ➖, 11↑ 1↓)
|
Contributor
Benchmarks: CompressionVortex (geomean): 0.999x ➖ unknown / unknown (0.994x ➖, 0↑ 0↓)
|
myrrc
force-pushed
the
myrrc/duckdb-column-stats
branch
from
46c5eaf to
276db60
Compare
myrrc
added
action/benchmark
github-actions
bot
removed
action/benchmark-sql
Contributor
File Sizes: TPC-H SF=1 on NVMENo file size changes detected. |
Contributor
File Sizes: TPC-H SF=10 on NVMENo file size changes detected. |
joseph-isaacs
added
the
action/benchmark
github-actions
bot
removed
the
action/benchmark
Contributor
|
Looks like some real regressions here. Opening all the files AoT is not a good idea, its very expensive. |
gatesn
reviewed
Apr 15, 2026
Contributor
gatesn
left a comment
gatesn
left a comment
There was a problem hiding this comment.
I think the regression might be eagerly merging all stats for all columns, when we only need min/max/str_len for columns that DuckDB asks us about
| column_index: usize, | ||
| ) -> &'a ColumnStatistics { | ||
| match &bind_data.stats { | ||
| DataSourceStatistics::All(items) => &items[column_index], |
Contributor
There was a problem hiding this comment.
We should lazily construct stats for each column. Could be way fewer columns that DuckDB asks for
| self.statistics.as_ref() | ||
| } | ||
|
|
||
| pub fn take_statistics(&mut self) -> Option<FileStatistics> { |
| self.footer.statistics() | ||
| } | ||
|
|
||
| pub fn take_file_stats(&mut self) -> Option<FileStatistics> { |
Signed-off-by: Mikhail Kot <to@myrrc.dev>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.