switch Buffer -> BufferHandle in PrimitiveArray #5929
+944
−730
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fleshes out the BufferHandle type more.
I hid the inner enum and introduced some extra methods to build/unwrap BufferHandles.
This removes the
PrimitiveArray::as_slicemethod, replacing it with aninto_buffer::<T>method which may allocate and copy a new buffer (if the handle points to device memory), or else provides a new Buffer pointing to the existing host memory.This PR is large but a lot of it is just adding
&'s and updating test code to use thebuffer!macro