feat: display tree with no metadata #5898
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Daniel King <[email protected]>
CodSpeed Performance ReportMerging this PR will improve performance by 10.71%Comparing Summary
Performance Changes
|
Codecov Report❌ Patch coverage is
☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
robert3005
approved these changes
Jan 9, 2026
Contributor
joseph-isaacs
left a comment
joseph-isaacs
left a comment
There was a problem hiding this comment.
I am not against this, just not sure we want to open up str eq as the best way to do array encoding equality
| DisplayArrayAs(self, options) | ||
| } | ||
|
|
||
| /// Display the tree of array encodings and lengths without metadata or buffers. |
| /// assert_eq!(format!("{}", array.display_tree_no_metadata()), expected); | ||
| /// ``` | ||
| pub fn display_tree_no_metadata(&self) -> impl Display { | ||
| DisplayArrayAs(self, DisplayOptions::TreeNoMetadataDisplay) |
Contributor
There was a problem hiding this comment.
do you think we want to make these option compose so you can take any subset?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.