Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add video to structured text in page model #789

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

sjoerdbeentjes
Copy link
Contributor

What changes were made

Added support for responsive videos in structured text

How to test or check results

to go /en/open-source and check if there's a video

Checks

@@ -1,2 +1,2 @@
export const datocmsEnvironment = 'multilingual-blogs';
export const datocmsEnvironment = 'video-captions';
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

TODO: run migration on primary environment en revert this change

@WesselSmit WesselSmit self-requested a review May 27, 2024 11:23
Copy link
Member

@WesselSmit WesselSmit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved after you revert the change to src/constants.mjs

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants