feat: inline variants by buffer lengths #17
Draft
+207
−24
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
INLINE_CAP
to 32This is inspired by Enum field align cause performance degradation about 10x rust-lang/rust#119247 (comment). However, I just choose six versions with buffers of fixed length 1,2,4,8,16,32 (maybe there is a better partition). The purpose is:
This is inspired by One more byte for inlined rust-analyzer/smol_str#53, which makes the compiler know the length range of each variant.
From my benchmarking, the performance improves on both x86-64 and aarch64.
I need to figure out why cloning empty is also faster.The results of the benchmark look weird. I write a simple for-loop to test the performance, which shows an expected result that the performance of cloning inline string is greatly improved at the cost of some extra instructions for the discriminant judgment.There are also cons: