Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tiny refactor and cleanup #75

Open
wants to merge 36 commits into
base: main
Choose a base branch
from
Open
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
more
fzyzcjy committed Jan 2, 2025

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
commit fce7267918dce260e8fc5842bfe85c25b45c9849
5 changes: 1 addition & 4 deletions verl/trainer/ppo/ray_trainer.py
Original file line number Diff line number Diff line change
@@ -209,10 +209,7 @@ def compute_timing_metrics(batch, timing_raw):

num_tokens_of_section = {
'gen': num_response_tokens,
'ref': num_overall_tokens,
'values': num_overall_tokens,
'critic': num_overall_tokens,
'actor': num_overall_tokens,
**{name: num_overall_tokens for name in ['ref', 'values', 'adv', 'update_critic', 'update_actor']},
}

return {