refactor: Refactor S3 configuration structure and fix Python 3.9 compatibility issues#73
Merged
MaojiaSheng merged 2 commits intovolcengine:mainfrom Feb 5, 2026
Merged
Conversation
…atibility issues - Extract S3-related configurations from AGFSConfig into a new S3Config class - Update agfs_manager.py to use the new S3Config structure - Modify test_config_validation.py to adapt to the new configuration structure - Update configuration example files to reflect the new configuration structure - Fix Python 3.9 compatibility issue in embedding_queue.py by replacing `EmbeddingMsg | None` with `Optional[EmbeddingMsg]`
MaojiaSheng
approved these changes
Feb 5, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Refactor S3 configuration structure and fix Python 3.9 compatibility issues
Related Issue
Type of Change
Changes Made
EmbeddingMsg | NonewithOptional[EmbeddingMsg]Testing
Checklist
Screenshots (if applicable)
Additional Notes
ov.conf example