refactor(source-map): reimplement and improve code quality #92
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
johnsoncodehk
commented
Nov 22, 2023
•
johnsoncodehk
commented
- API and data format are more standardized
- Completely rewritten for readability
- Add tests
- Add readme
|
All those changes will probably break experimental language modules like this one https://github.com/rchl/volar-component-types/blob/main/src/volar/volar.ts ? Granted they are experimental but it will be a pain if I'll have to figure out how to get it up and running again. Is there a chance for some migration guide? |
|
@rchl https://github.com/rchl/volar-component-types is listed as #85 and I will submit a PR for it after 2.0 is released |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.