Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(typescript): fix folding, symbols for TS plugin for .ts #227

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from
Draft

fix(typescript): fix folding, symbols for TS plugin for .ts #227

wants to merge 1 commit into from

Conversation

johnsoncodehk
Copy link
Member

@ShenQingchuan ShenQingchuan mentioned this pull request Jul 22, 2024
Closed
@ShenQingchuan
Copy link

ShenQingchuan commented Jul 23, 2024 •
edited
Loading

Hi @johnsoncodehk, is there any practical way that I can use this modified code in Vue Vine source code and check whether it does work?

Milad335t
Milad335t suggested changes Oct 22, 2024
View reviewed changes
Copy link

@Milad335t Milad335t left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Mil

@ShenQingchuan
Copy link

ShenQingchuan commented Oct 23, 2024 •
edited
Loading

@johnsoncodehk

This feature in Vue Vine extension seems to be resolved in the last few versions of Volar, so I think we may close this draft? or is there anything else left?

Another problem is linked with Vue Vine vineProp jump to definition, but it'd be better for me to open a new issue/PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Milad335t Milad335t Milad335t requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@johnsoncodehk @ShenQingchuan @Milad335t