Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: export replaceTscContent for downstream usage #223

Merged
merged 4 commits into from
Aug 17, 2024

Conversation

so1ve
Copy link
Contributor

@so1ve so1ve commented Jul 8, 2024

No description provided.

Comment on lines 10 to 16
export function replaceTscContent(
tsc: string,
proxyApiPath: string,
extraSupportedExtensions: string[],
extraExtensionsToRemove: string[],
getLanguagePluginsFile = __filename,
) {

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some JSDoc would be appreciated

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What kind of jsdoc? Description, parameters or more?

Copy link

@ematipico ematipico Jul 27, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Description of the function and of the parameters

Copy link

pkg-pr-new bot commented Aug 17, 2024

commit: 587e51d

@volar/eslint

pnpm add https://pkg.pr.new/volarjs/volar.js/@volar/eslint@223

@volar/jsdelivr

pnpm add https://pkg.pr.new/volarjs/volar.js/@volar/jsdelivr@223

@volar/kit

pnpm add https://pkg.pr.new/volarjs/volar.js/@volar/kit@223

@volar/language-core

pnpm add https://pkg.pr.new/volarjs/volar.js/@volar/language-core@223

@volar/language-server

pnpm add https://pkg.pr.new/volarjs/volar.js/@volar/language-server@223

@volar/language-service

pnpm add https://pkg.pr.new/volarjs/volar.js/@volar/language-service@223

@volar/monaco

pnpm add https://pkg.pr.new/volarjs/volar.js/@volar/monaco@223

@volar/source-map

pnpm add https://pkg.pr.new/volarjs/volar.js/@volar/source-map@223

@volar/test-utils

pnpm add https://pkg.pr.new/volarjs/volar.js/@volar/test-utils@223

@volar/typescript

pnpm add https://pkg.pr.new/volarjs/volar.js/@volar/typescript@223

@volar/vscode

pnpm add https://pkg.pr.new/volarjs/volar.js/@volar/vscode@223

Open in Stackblitz

@johnsoncodehk johnsoncodehk merged commit 9b7d91e into volarjs:master Aug 17, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants