Vojtech Masa - solution
- I didn't manage to follow TDD perfectly. Normally I would, but I was afraid I can't code everything within the given time frame.
- Some more tests should be implemented, especially for negative scenarios.
- A service layer or an object representing BusyFlights airline (following DDD) should be implemented (extract from the controller).
- Constraint for max 4 passengers in the request needs to be implemented. Would be located in Business objects and cause return HTTP error code.
- Constraints for codes length (3 chars) should be implemented. Would be located in Business objects and cause return HTTP error code.
- Classes should be divided into packages more carefully.
- Timezone - I don't see in the assignment how to deal with Timezones. There is no information from the API in which timezone is the localdate. Assuming it is always in UTC, but should be the UTC information present in the response? Currently I implemented it that it is present for ToughJet, but not for CrazyAir (should be rewritten).
- For translating between POJOs, a reflection could be used (or some 3rd party library), however I am not keen on using reflexion.
Travix - Problem to be solved
Background:
BusyFlights is a flights search solution which aggregates flight results initially from 2 different suppliers (CrazyAir and ToughJet). A future iteration (not part of the test) may add more suppliers.
Recommended duration of test:
Allocate no more than 90 minutes to complete this exercise. An incomplete solution is acceptable but documenting any remaining tasks and next steps is expected.
What is required:
Use this GitHub repository as a base to implement the Busy Flights service that should produce an aggregated result from both CrazyAir and ToughJet. The result should be a JSON response which contains a list of flights ordered by fare which has the following attributes:
Busy Flights API
Request
| Name | Description |
|---|---|
| origin | 3 letter IATA code(eg. LHR, AMS) |
| destination | 3 letter IATA code(eg. LHR, AMS) |
| departureDate | ISO_LOCAL_DATE format |
| returnDate | ISO_LOCAL_DATE format |
| numberOfPassengers | Maximum 4 passengers |
Response
| Name | Description |
|---|---|
| airline | Name of Airline |
| supplier | Eg: CrazyAir or ToughJet |
| fare | Total price rounded to 2 decimals |
| departureAirportCode | 3 letter IATA code(eg. LHR, AMS) |
| destinationAirportCode | 3 letter IATA code(eg. LHR, AMS) |
| departureDate | ISO_DATE_TIME format |
| arrivalDate | ISO_DATE_TIME format |
The service should connect to the both the suppliers using HTTP.
CrazyAir API
Request
| Name | Description |
|---|---|
| origin | 3 letter IATA code(eg. LHR, AMS) |
| destination | 3 letter IATA code(eg. LHR, AMS) |
| departureDate | ISO_LOCAL_DATE format |
| returnDate | ISO_LOCAL_DATE format |
| passengerCount | Number of passengers |
Response
| Name | Description |
|---|---|
| airline | Name of the airline |
| price | Total price |
| cabinclass | E for Economy and B for Business |
| departureAirportCode | Eg: LHR |
| destinationAirportCode | Eg: LHR |
| departureDate | ISO_LOCAL_DATE_TIME format |
| arrivalDate | ISO_LOCAL_DATE_TIME format |
ToughJet API
Request
| Name | Description |
|---|---|
| from | 3 letter IATA code(eg. LHR, AMS) |
| to | 3 letter IATA code(eg. LHR, AMS) |
| outboundDate | ISO_LOCAL_DATE format |
| inboundDate | ISO_LOCAL_DATE format |
| numberOfAdults | Number of passengers |
Response
| Name | Description |
|---|---|
| carrier | Name of the Airline |
| basePrice | Price without tax(doesn't include discount) |
| tax | Tax which needs to be charged along with the price |
| discount | Discount which needs to be applied on the price(in percentage) |
| departureAirportName | 3 letter IATA code(eg. LHR, AMS) |
| arrivalAirportName | 3 letter IATA code(eg. LHR, AMS) |
| outboundDateTime | ISO_INSTANT format |
| inboundDateTime | ISO_INSTANT format |
What you need to provide:
- A solution that meets the above requirements.
- The implementation should be made as close to 'production ready' as possible within the time constraints.
It is fine to change any of the supplied application code, if you choose to do so please add comments to indicate what has changed and why.
Note
Please clone this project then create your own repository from it. Do not fork/branch this project when creating your solution as it will be visible to other applicants.