Skip to content

fix: handle Windows path stripping failures gracefully #93

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
branchseer merged 2 commits into from
Jan 13, 2026
Merged

fix: handle Windows path stripping failures gracefully #93

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
c57008d
fix: handle Windows path stripping failures gracefully
branchseer Jan 11, 2026
c645ad1
update comment
branchseer Jan 13, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 9 additions & 11 deletions crates/vite_task/src/session/execute/spawn.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -174,17 +174,15 @@ where
let path_writes = &mut track_result.path_writes;

for access in termination.path_accesses.iter() {
let relative_path = access
.path
.strip_path_prefix(workspace_root, |strip_result| {
let Ok(stripped_path) = strip_result else {
return None;
};
Some(RelativePathBuf::new(stripped_path).map_err(|err| {
anyhow::anyhow!("Invalid relative path '{}': {}", stripped_path.display(), err)
}))
})
.transpose()?;
let relative_path = access.path.strip_path_prefix(workspace_root, |strip_result| {
let Ok(stripped_path) = strip_result else {
return None;
};
// On Windows, paths are possible to be still absolute after stripping the workspace root.
// For example: c:\workspace\subdir\c:\workspace\subdir
// Just ignore those accesses.
RelativePathBuf::new(stripped_path).ok()
});

let Some(relative_path) = relative_path else {
// Ignore accesses outside the workspace
Expand Down