refactor: remove lifetime and cwd from WorkspaceRoot#62
Merged
branchseer merged 1 commit intomainfrom Dec 18, 2025
Merged
Conversation
Member
Author
This stack of pull requests is managed by Graphite. Learn more about stacking. |
fengmk2
approved these changes
Dec 18, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

TL;DR
Refactored
WorkspaceRootto useArc<AbsolutePath>for the path field and separated thecwdfield from the struct.What changed?
WorkspaceRootstruct to useArc<AbsolutePath>for thepathfield instead of a referencecwdfield fromWorkspaceRootand made it a separate return value infind_workspace_rootfind_workspace_rootto return a tuple of(WorkspaceRoot, RelativePathBuf)instead of justWorkspaceRootfind_workspace_rootto handle the new return typeworkspace_root.pathto properly dereference the Arc when neededHow to test?
Why make this change?
This change improves memory management by using
Arc(Atomic Reference Counting) for the workspace path, allowing it to be shared efficiently across different components without lifetime constraints. Separating thecwdfrom theWorkspaceRootstruct makes the API more explicit about what belongs to the workspace definition versus contextual information about the current working directory.