Skip to content

feat: move script parsing to vite_shell and add source spans#55

Merged
branchseer merged 2 commits intomainfrom
12-10-feat_move_script_parsing_to_vite_shell_and_add_source_spans
Dec 10, 2025
Merged

feat: move script parsing to vite_shell and add source spans#55
branchseer merged 2 commits intomainfrom
12-10-feat_move_script_parsing_to_vite_shell_and_add_source_spans

Conversation

@branchseer
Copy link
Copy Markdown
Member

@branchseer branchseer commented Dec 10, 2025

TL;DR

Migrate shell parsing functionality from vite_task to a dedicated vite_shell crate, improving shell command parsing with better location tracking.

What changed?

  • Moved TaskParsedCommand and shell parsing logic from vite_task/cmd.rs to the vite_shell crate
  • Enhanced the shell parser to track source locations of commands in addition to parsing them
  • Updated try_parse_as_and_list to return both parsed commands and their source ranges
  • Updated the workspace to use the new shell parsing functionality
  • Pinned to a specific git revision of brush-parser to fix a bug with AST node locations

Copy link
Copy Markdown
Member Author

This stack of pull requests is managed by Graphite. Learn more about stacking.

@branchseer branchseer marked this pull request as ready for review December 10, 2025 11:08
@branchseer branchseer requested a review from fengmk2 December 10, 2025 11:12
@branchseer branchseer merged commit e9b020d into main Dec 10, 2025
7 checks passed
@Brooooooklyn Brooooooklyn deleted the 12-10-feat_move_script_parsing_to_vite_shell_and_add_source_spans branch December 11, 2025 06:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants