fix: avoid Windows cached stdio drain hang#486
Open
kazupon wants to merge 1 commit into
Open
Conversation
Co-authored-by: GPT-5 Codex <codex@openai.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #485
Windows cached execution could hang after the first command in a compound script when the direct child had exited but a descendant still held inherited stdout/stderr pipe handles.
This updates
run_childto poll stdio drain and direct child wait concurrently, then signal IPC drain as soon as the child exits.It also adds a Windows-only E2E fixture that models the inherited-handle case and verifies the next
&&command is planned to run instead of waiting on pipe EOF.