fix: find PATH case-insensitively on Windows#29
Merged
branchseer merged 6 commits intomainfrom Nov 12, 2025
Merged
Conversation
Member
Author
This stack of pull requests is managed by Graphite. Learn more about stacking. |
branchseer
changed the title
Brooooooklyn
changed the base branch from
11-12-refactor_make_taskenvs_resolve_accept_env_iterator_parameter
to
graphite-base/29
This reverts commit 1f1c73b.
Add comprehensive tests for the Windows PATH case-insensitivity handling: - test_windows_path_case_insensitive_mixed_case: Verifies mixed case "Path" is preserved and modified correctly - test_windows_path_case_insensitive_uppercase: Tests uppercase "PATH" baseline case - test_windows_path_created_when_missing: Ensures new "PATH" is created when missing - test_unix_path_case_sensitive: Regression test to ensure Unix maintains case-sensitive PATH behavior All tests verify exact PATH values using OsStr comparisons. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <noreply@anthropic.com>
Brooooooklyn
force-pushed
the
11-12-fix_find_path_case-sensitively_on_windows
branch
from
58082f0 to
f1f5f19
Compare
Brooooooklyn
force-pushed
the
graphite-base/29
branch
from
3fb291a to
33381fc
Compare
fengmk2
reviewed
Nov 12, 2025
Brooooooklyn
force-pushed
the
11-12-fix_find_path_case-sensitively_on_windows
branch
from
f1f5f19 to
942448c
Compare
fengmk2
approved these changes
Nov 12, 2025
Brooooooklyn
deleted the
11-12-fix_find_path_case-sensitively_on_windows
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Make sure to find the case-insensitive PATH for inserting
node_modules/.bin