refactor: simplify fspy::Command API and add pre_exec hook#23
Merged
branchseer merged 6 commits intomainfrom Nov 11, 2025
Merged
Conversation
fengmk2
approved these changes
Nov 11, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

TL;DR
Refactored the
fspycrate to simplify the API by removing theSpystruct and makingCommandthe primary entry point.What changed?
Spystruct and replaced it with a globalSPY_IMPLstatic usingLazyLockCommand::new()the primary entry point for creating commands instead ofSpy::new_command()SpyInnertoSpyImpland moved spawn implementation into this structpre_execsupport toCommandon Unix platformsCommandfields private with proper accessorsderive_moredependency for better Debug implementationsHow to test?
Why make this change?
This refactoring simplifies the API by removing an unnecessary abstraction layer. The
Spystruct was mostly a wrapper around creating commands, and having a global instance was redundant. By makingCommandthe primary entry point and using a global implementation internally, the API becomes more intuitive and follows patterns similar to standard libraries. The change also improves encapsulation by making fields private and adding proper accessors.