Repository navigation
feat(check): support --fix-dangerously - #3413
chbaefront wants to merge 7 commits into
Conversation
Support dangerous lint fixes and suggestions in vp check. Add CLI snapshot coverage and update the documentation.
|
@codex review |
Codex Review Summary: ✅ CompletedThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
Support dangerous lint fixes and suggestions in vp check. Add CLI snapshot coverage and update the documentation. - fix(ci): restore bundled tool versions
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: f4ff52c53b
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
Support dangerous lint fixes and suggestions in vp check. Add CLI snapshot coverage and update the documentation. - fix(ci): prepare Yarn before lockfile-only snapshot
There was a problem hiding this comment.
Why is the Yarn fixture changed in this PR?
There was a problem hiding this comment.
Added a yarn --version setup step to prepare the pinned Yarn before testing --lockfile-only. This prevents download progress from leaking into the snapshot, as seen in the macOS CI failure.
The existing option and file assertions remain unchanged. All CI checks are now passing.
https://github.com/voidzero-dev/vite-plus/actions/runs/42771771010/job/129681704552?pr=3413
The CI snapshot test failed because ⠿m Downloading yarn <version>... <size> B (<size> B/s) leaked into the captured output before the warning, causing a mismatch with the stored snapshot.
There was a problem hiding this comment.
This looks flaky. Could you drop the fixture change from this PR? If it turns out to be a real bug, please open a separate PR for it.
There was a problem hiding this comment.
I reverted the yarn fixture changes in the CLI snapshot to the previous version and pushed the update again!
There was a problem hiding this comment.
after reverting the Yarn fixture change, the Yarn test passed, but two other macOS snapshot tests failed with similar download progress artifacts:
- Shard 1:
command_update_bun_with_workspace—Downloading bun ... - Shard 2:
command_outdated_pnpm10_with_workspace—Downloading pnpm ...
This appears to be an intermittent issue with download progress rendering or PTY capture, rather than the --fix-dangerously change. I’ll keep the unrelated fixture changes out of this PR.
Support dangerous lint fixes and suggestions in vp check. Add CLI snapshot coverage and update the documentation. - fix(fixture): yarn fixture restore
jong-kyung
left a comment
jong-kyung
left a comment
There was a problem hiding this comment.
It all looks good to me
Support dangerous lint fixes and suggestions in vp check. Add CLI snapshot coverage and update the documentation.
closes #3394