Repository navigation
Conversation
|
@codex review |
Codex Review Summary: ✅ CompletedThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
|
Codex Review: Didn't find any major issues. Already looking forward to the next diff. Reviewed commit: ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
36f8cda to
7b135bd
Compare
|
@codex review |
7b135bd to
dd40161
Compare
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 7b135bd2eb
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
dd40161 to
43a3ef3
Compare
- Peek leading -C <dir> in CompleteEnv and switch process cwd before running completion, so cwd-sensitive task completers (vp run / vpr) resolve tasks from the target directory. - Expand leading ~ and ~/ (and Windows ~\ ) in resolve_chdir during both completion and normal execution. - Decode POSIX quotes and backslash escapes in bash and zsh via shlex. - Support -C=<dir> reassembly in bash completion and insert run for vpr in-place, avoiding bash 3.2 array slicing bugs. - Add ValueHint::DirPath to -C flag.
|
@codex review |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 817c3a333c
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
… in tests - Keep apply_chdir strictly literal during normal runtime execution, matching path.resolve and POSIX cd semantics. - Resolve tilde paths via resolve_completion_chdir exclusively in completion mode. - Use vpt mkdir and vpt rm in assert_completion.bash per AGENTS.md portability guidelines.
6fcdc6a to
10d31b5
Compare
|
@codex review |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 10d31b507a
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
10d31b5 to
bbffecd
Compare
…ogic and Shell::Posix detection
bbffecd to
236616b
Compare
|
@codex review |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 236616bbe1
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
|
Closing. Shell-specific tilde escaping in completion arguments requires a broader redesign. |
Fix shell completion for
-Candvpr:--in completion arguments so-C <dir>,-C<dir>, and-C=<dir>correctly switch the target working directory for task suggestions instead of falling back to the current directory.vpr -Cforms to invalid syntaxvp run -C ...instead ofvp -C ... run, preserving task completion across separate, attached, and equals styles.=(e.g.-C=<dir>), and add directoryValueHintto-C.