refactor: clean up minification benchmark data typing#150
Merged
fengmk2 merged 1 commit intovoidzero-dev:mainfrom Mar 20, 2026
Merged
refactor: clean up minification benchmark data typing#150fengmk2 merged 1 commit intovoidzero-dev:mainfrom
fengmk2 merged 1 commit intovoidzero-dev:mainfrom
Conversation
yangshun
commented
Mar 20, 2026
| import minificationData from "../../../data/minification-benchmarks-data.json"; | ||
|
|
||
| export const popularMinifiers = ["terser", "esbuild", "@swc/core", "uglify-js", "oxc-minify"]; | ||
| const MINIFIERS = [ |
Contributor
Author
There was a problem hiding this comment.
Removes the need for long if/else chain in the original function.
Adding new minifiers will now be easier, just add it as a new item in the array.
| ); | ||
| } | ||
|
|
||
| function getBenchmarkData(data: unknown): MinificationBenchmarkData { |
Contributor
Author
There was a problem hiding this comment.
The previous version used any, which is not typesafe.
Unfortunately it takes 60 more lines of code to make TypeScript happy. Happy to revert back to any if not desired / deemed overkill.
| value = Math.round(((originalSize - minzippedBytes) / originalSize) * 100 * 10) / 10; | ||
| } | ||
|
|
||
| data.push({ |
Contributor
Author
There was a problem hiding this comment.
The main aim was to remove this.
fengmk2
approved these changes
Mar 20, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Test plan