fix(transform): strip non-Angular class decorators from compiled output#48
Merged
Brooooooklyn merged 1 commit intomainfrom Mar 3, 2026
Merged
Conversation
When a class had both Angular decorators (@component, @directive, etc.) and non-Angular class decorators (e.g. @UntilDestroy()), only the Angular decorator was removed during compilation. The non-Angular decorator remained in the output, producing invalid JS since it decorated a compiled class with static ɵcmp/ɵfac fields rather than a plain class declaration. Fix by collecting ALL class-level decorator spans for removal when any Angular decorator is present, instead of only the single Angular one. - Close #44 Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Member
Author
This stack of pull requests is managed by Graphite. Learn more about stacking. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When a class had both Angular decorators (@component, @directive, etc.)
and non-Angular class decorators (e.g. @UntilDestroy()), only the Angular
decorator was removed during compilation. The non-Angular decorator
remained in the output, producing invalid JS since it decorated a compiled
class with static ɵcmp/ɵfac fields rather than a plain class declaration.
Fix by collecting ALL class-level decorator spans for removal when any
Angular decorator is present, instead of only the single Angular one.
Co-Authored-By: Claude Opus 4.6 noreply@anthropic.com
Note
Cursor Bugbot is generating a summary for commit 849572f. Configure here.