fix: always use Full template compilation mode, matching Angular's local compilation behavior#19
Merged
Brooooooklyn merged 1 commit intomainfrom Feb 10, 2026
Conversation
Brooooooklyn
force-pushed
the
fix/always-full-template-compilation-mode
branch
from
80e21d4 to
adae378
Compare
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
Brooooooklyn
force-pushed
the
fix/always-full-template-compilation-mode
branch
from
adae378 to
b3ed7fd
Compare
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
Bugbot Autofix is OFF. To automatically fix reported issues with Cloud Agents, enable Autofix in the Cursor dashboard.
…cal compilation behavior OXC is a single-file compiler equivalent to Angular's local compilation mode. In local mode, Angular always sets hasDirectiveDependencies=true (handler.ts:1257), so DomOnly mode is never used for component templates. Remove the conditional DomOnly/Full logic and always use Full mode. - Remove standalone_explicitly_set and has_directive_dependencies from ComponentMetadata - Remove has_any_non_pipe_import_elements() heuristic function - Remove useDomOnlyMode from NAPI bindings and TypeScript types - Remove shouldUseDomOnlyMode() from comparison tool - Fix build-test script to use comma-separated cargo features - Fix fixture runner to use experimental-local compilation mode matching OXC - Add test asserting standalone components use Full mode - Update existing DomOnly tests to assert Full mode Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Brooooooklyn
force-pushed
the
fix/always-full-template-compilation-mode
branch
from
b3ed7fd to
34e5286
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
OXC is a single-file compiler equivalent to Angular's local compilation mode. In local mode, Angular always sets hasDirectiveDependencies=true (handler.ts:1257), so DomOnly mode is never used for component templates. Remove the conditional DomOnly/Full logic and always use Full mode.
Note
Medium Risk
Changes template codegen to always emit Full-mode instructions and removes the
useDomOnlyModetoggle across Rust + NAPI, which can affect generated output and any consumers relying on DomOnly-specific behavior or APIs.Overview
Component template compilation is now always emitted in
TemplateCompilationMode::Full(matching Angular local compilation), removing the prior DomOnly-vs-Full decision logic.This deletes DomOnly-related metadata/heuristics (e.g.
standalone_explicitly_set,has_directive_dependencies, and pipe-vs-directive import detection), removes theuseDomOnlyModeoption from NAPI/TypeScript bindings and the e2e compare tooling, and updates integration tests/snapshots to assert Full-mode instructions (ɵɵelementStart,ɵɵlistener,ɵɵproperty).Written by Cursor Bugbot for commit 34e5286. This will update automatically on new commits. Configure here.