fix: import elision for namespace imports, arrow function bodies, empty imports, and star export barrels#18
Merged
Brooooooklyn merged 1 commit intomainfrom Feb 9, 2026
Conversation
…ty imports, and star export barrels
- Elide namespace imports (`import * as X`) when only used in type positions
- Traverse arrow function bodies to find value references (e.g., `forwardRef(() => Comp)`)
- Remove empty imports (`import {} from 'module'`)
- Fix cross-file type detection through star export barrels (`export * from './module'`)
- Remove duplicate match arms in expand_safe_reads
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
import * as X) when only used in type positionsforwardRef(() => Comp))import {} from 'module')export * from './module')Note
Medium Risk
Touches import-elision logic and cross-file export resolution, which can change emitted JS and potentially break runtime behavior if a value import is incorrectly removed. Changes are well-scoped and backed by targeted regression tests.
Overview
Improves Angular import elision accuracy by treating namespace imports (
import * as X) as elidable when they’re only referenced in type positions, and by traversing arrow function bodies to detect value uses (e.g.forwardRef(() => Comp)) so those imports are preserved.Extends cross-file type-only detection to follow
export * from '...'barrel chains when deciding whether an imported symbol is type-only, and updates filtering to drop empty imports (import {} from 'module') entirely. Cleans upexpand_safe_readsby removing duplicate/unused match arms in temporary-detection logic and adds regression tests for the above scenarios.Written by Cursor Bugbot for commit 83e53da. This will update automatically on new commits. Configure here.