fix: generate tmp variables for safe navigation on binary/ternary/unary expressions#16
Merged
Brooooooklyn merged 1 commit intomainfrom Feb 9, 2026
Conversation
…ry expressions needs_temporary_in_safe_access() in expand_safe_reads was missing match arms for IrExpression::Binary, Ternary, Not, and Unary. When a safe property read like (pipeBind(...) || fallback)?.name had a Binary receiver, the function fell through to `_ => false` instead of recursing into operands to detect the pipe binding. This caused the pipe to be evaluated twice with inflated binding slot indices. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
needs_temporary_in_safe_access() in expand_safe_reads was missing match arms for IrExpression::Binary, Ternary, Not, and Unary. When a safe property read like (pipeBind(...) || fallback)?.name had a Binary receiver, the function fell through to
_ => falseinstead of recursing into operands to detect the pipe binding. This caused the pipe to be evaluated twice with inflated binding slot indices.Note
Medium Risk
Touches compiler IR transformation logic for safe navigation and temporary allocation, which can subtly affect generated JS semantics and slot/indexing across templates, though the change is localized and covered by a new regression test.
Overview
Fixes
expand_safe_readstemporary-detection so safe-navigation receivers that areIrExpression::Binary,Ternary,Not, orUnaryare recursively inspected for side-effecting subexpressions (notably pipe bindings), ensuring a temp variable is generated instead of re-evaluating the receiver.Adds an integration snapshot test covering
((data$ | async) || fallback)?.name, asserting the compiled output assigns the binary/pipe expression totmp_*and uses it for the null guard and property access (avoiding duplicatepipeBindcalls and slot/index drift).Written by Cursor Bugbot for commit e1b896d. This will update automatically on new commits. Configure here.