Conversation
Member
|
I think makes sense to trigger and settle on every restart. Missed events are not just a first boot issues theoretically. |
eholzbach
changed the title
eholzbach
marked this pull request as ready for review
September 20, 2026 15:58
eholzbach
force-pushed
the
eudev
branch
2 times, most recently
from
September 21, 2026 23:22
470c015 to
5f2f350
Compare
| ( | ||
| i=0 | ||
| while [ ! -S /run/udev/control ] && [ "$i" -lt 50 ]; do | ||
| sleep 0.1 |
Member
There was a problem hiding this comment.
using a non-integer time value for sleep is not posix, this may cause issues for some users
Contributor
Author
There was a problem hiding this comment.
Fractions are available in coreutils and busybox. I didn't consider Void users running alternative userlands. Will do some digging.
Contributor
Author
There was a problem hiding this comment.
I couldn't come up with a better answer than accept waiting for a full second. Updated.
Member
There was a problem hiding this comment.
then you'll want to remove the loop
Udev is initially ran unsupervised then restarted by runit. Events that happen during restart may leave devices with incorrect permissions. This waits for the socket to become available then triggers a rescan. void-linux/void-runit#135
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
On restart, spawn a sub-shell that waits for the supervised instance of udev socket to come up, then rescan devices. This corrects permissions of devices that appear between sessions. Fixes void-linux/void-runit#135