QuickAccess: add quick note #2373
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tamlok
reviewed
Apr 6, 2023
tamlok
reviewed
Apr 12, 2023
src/widgets/viewsplit.h
Outdated
| @@ -92,6 +92,8 @@ namespace vnotex | |||
|
|
|||
| void distributeSplitsRequested(); | |||
|
|
|||
| void newNoteRequested(ViewSplit *p_split, const QVector<int> &p_type, const QString &p_path); | |||
There was a problem hiding this comment.
Is this function necessary? Can we just emit the final signal here instead of via the ViewArea?
tamlok
reviewed
Apr 18, 2023
src/widgets/notebookexplorer.cpp
Outdated
| auto node = checkNotebookAndGetCurrentExploredFolderNode(); | ||
| if (!node) { | ||
| return; | ||
| if (p_type.length() <= c_defaultCreateNote) { |
There was a problem hiding this comment.
c_defaultCreateNode is 0. So what does this logic mean?
There was a problem hiding this comment.
It is mainly used to determine p_type, Is it the default, is it single, is it multiple.
src/widgets/notebookexplorer.cpp
Outdated
| paras->m_newFile = true; | ||
| emit VNoteX::getInst().openNodeRequested(dialog.getNewNode().data(), paras); | ||
| } | ||
| } else if (p_type.length() == c_singleQuickNote) { |
There was a problem hiding this comment.
Want to use < 1 ，= 1, but that's a magic constant, which is hard to understand
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Impl: #2351
In this modification, the function of double-click tab to quickly create notes is added. do not adjust the template for now.