Skip to content

Adding default password criteria to sample config #95

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Adding default password criteria to sample config #95

wants to merge 2 commits into from

Conversation

minhducsun2002
Copy link
Contributor

This enables setting custom rules for passwords.

However, whether this option is mandatory in the configuration is up to upstream maintainers.

@dungwinux
Copy link
Member

@minhducsun2002, this can be quite messy, you know

@dungwinux dungwinux added the question Further information is requested label Oct 10, 2019
@minhducsun2002
Copy link
Contributor Author

minhducsun2002 commented Oct 10, 2019

Hardcoding checks in the web app is not a good way to implement criteria for strings.

The more preferred method is a regular expression.

@dungwinux
Copy link
Member

But hey, I can't find your implementation. There's only sample change

@minhducsun2002
Copy link
Contributor Author

I see that you seem to be serving contest.json's content directly, so I simply put it there.

If you mean to add checks for this feature or Enquire entries to change that, sorry, working on that.

@dungwinux
Copy link
Member

That's not how the config system work. Currently, it parses config while preserving as much as possible. That means it only read white-listed properties. See in src/util/config/contestConfig.js for more details.

@minhducsun2002
Copy link
Contributor Author

Should work properly now.

@enbugging
Copy link
Contributor

Hmm, anyone?

@dungwinux
Copy link
Member

dungwinux commented Jun 7, 2021

Hmm, anyone?

@MegumiTadokoro Feel free to contribute, at least after rebasing or resolving conflict

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
question Further information is requested
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants