This repository has been archived by the owner on Jun 17, 2024. It is now read-only.
Adds support for generic responses #19
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
added
the
skylerto
commented
Jul 16, 2019
skylerto
commented
Jul 16, 2019
Uses Go `map[string]string` instead of `DeploymentResourceData` to abstract generic properties from the responses of vRA deployment resources. This solves issues where we might want to handle custom properties on the blueprints, as well as XaaS blueprints that contain entirely custom properties. Signed-off-by: skylerto <[email protected]>
skylerto
force-pushed
the
generic-response
branch
from
cdb4e40 to
ff1922c
Compare
|
This also might resolve #16. |
|
Looking to see if the currently solution, with modifications similar to #21 can be used to achieve the same result. |
|
@markpeek would love a review or test of this PR. It essentially exposes the raw data from the resource views endpoint within vRA so that it can be consumed in any desired way. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uses Go
map[string]stringinstead ofDeploymentResourceDatato abstract generic properties from the responses of vRA deployment
resources.
This solves issues where we might want to handle custom properties on
the blueprints, as well as XaaS blueprints that contain entirely custom
properties.
Signed-off-by: skylerto [email protected]