Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixed dead code issue #192

Merged
merged 1 commit into from
Oct 28, 2020
Merged

Fixed dead code issue #192

merged 1 commit into from
Oct 28, 2020

Conversation

sshedi
Copy link
Contributor

@sshedi sshedi commented Oct 28, 2020

Compare return values before bailing out

Signed-off-by: Shreenidhi Shedi [email protected]

@sshedi
Fixed dead code issue
4c45258 
Compare return values before bailing out

Signed-off-by: Shreenidhi Shedi <[email protected]>
tapakund
tapakund approved these changes Oct 28, 2020
View reviewed changes
Copy link
Contributor

@tapakund tapakund left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

keerthanakalyan
keerthanakalyan approved these changes Oct 28, 2020
View reviewed changes
Copy link
Contributor

@keerthanakalyan keerthanakalyan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@keerthanakalyan keerthanakalyan merged commit e691a7e into vmware:dev Oct 28, 2020
@sshedi sshedi deleted the fix-dead-code branch October 28, 2020 12:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tapakund tapakund tapakund approved these changes

@keerthanakalyan keerthanakalyan keerthanakalyan approved these changes

Assignees
No one assigned
Labels
cla-not-required
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@sshedi @tapakund @keerthanakalyan @vmwclabot