Skip to content

Make HttpRequestOptions accept 'headers' parameter when Axios request. #3211

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
sjiang-cb merged 1 commit into from
Nov 15, 2024
Merged

Make HttpRequestOptions accept 'headers' parameter when Axios request. #3211

sjiang-cb merged 1 commit into from
Nov 15, 2024

Conversation

@sjiang-cb
Copy link
Contributor

@sjiang-cb sjiang-cb commented Nov 11, 2024

No description provided.

@github-advanced-security
Copy link

github-advanced-security bot commented Nov 11, 2024

This pull request sets up GitHub code scanning for this repository. Once the scans have completed and the checks have passed, the analysis results for this pull request branch will appear on this overview. Once you merge this pull request, the 'Security' tab will show more code scanning analysis results (for example, for the default branch). Depending on your configuration and choice of analysis tool, future pull requests will be annotated with code scanning analysis results. For more information about GitHub code scanning, check out the documentation.

1 similar comment
@github-advanced-security
Copy link

github-advanced-security bot commented Nov 11, 2024

This pull request sets up GitHub code scanning for this repository. Once the scans have completed and the checks have passed, the analysis results for this pull request branch will appear on this overview. Once you merge this pull request, the 'Security' tab will show more code scanning analysis results (for example, for the default branch). Depending on your configuration and choice of analysis tool, future pull requests will be annotated with code scanning analysis results. For more information about GitHub code scanning, check out the documentation.

github-advanced-security[bot]
github-advanced-security bot found potential problems Nov 11, 2024
View reviewed changes
package.json
{
"name": "@singleton-i18n/js-core-sdk-server",
"version": "0.5.7",
"version": "0.5.8",

Check notice

Code scanning / Tslint (reported by Codacy)

" should be ' Note

" should be '
package.json
"changelogHistory": [
{
"date": "11/11/24",
"version": "0.5.8",

Check notice

Code scanning / Tslint (reported by Codacy)

" should be ' Note

" should be '
package.json
{
"date": "11/11/24",
"version": "0.5.8",
"notes": [

Check notice

Code scanning / Tslint (reported by Codacy)

" should be ' Note

" should be '
package.json
"version": "0.5.8",
"notes": [
{
"description": "Make HttpRequestOptions accept 'headers' parameter when Axios request."

Check notice

Code scanning / Tslint (reported by Codacy)

" should be ' Note

" should be '
github-advanced-security[bot]
github-advanced-security bot found potential problems Nov 11, 2024
View reviewed changes
.github/workflows/node.js.yml
uses: actions/checkout@main
- name: Run Codacy Analysis CLI
uses: codacy/codacy-analysis-cli-action@master
uses: codacy/codacy-analysis-cli-action@master

Check warning

Code scanning / Semgrep (reported by Codacy)

An action sourced from a third-party repository on GitHub is not pinned to a full length commit SHA. Pinning an action to a full length commit SHA is currently the only way to use an action as an immutable release. Warning

An action sourced from a third-party repository on GitHub is not pinned to a full length commit SHA. Pinning an action to a full length commit SHA is currently the only way to use an action as an immutable release.
github-advanced-security[bot]
github-advanced-security bot found potential problems Nov 11, 2024
View reviewed changes
jhua-vmware
jhua-vmware previously approved these changes Nov 11, 2024
View reviewed changes
github-advanced-security[bot]
github-advanced-security bot found potential problems Nov 14, 2024
View reviewed changes
samples/client/js/package.json
},
"dependencies": {
"@singleton-i18n/js-core-sdk": "file:../../../singleton-i18n-js-core-sdk-0.5.7.tgz",
"@singleton-i18n/js-core-sdk": "file:../../../singleton-i18n-js-core-sdk-0.5.8.tgz",

Check notice

Code scanning / Tslint (reported by Codacy)

" should be ' Note

" should be '
samples/client/js/package.json
"jest": "^24.9.0",
"webpack": "^4.39.1",
"webpack-cli": "^3.3.6"
"jest": "^29.7.0",

Check notice

Code scanning / Tslint (reported by Codacy)

" should be ' Note

" should be '
samples/client/js/package.json
"webpack": "^4.39.1",
"webpack-cli": "^3.3.6"
"jest": "^29.7.0",
"webpack": "^5.96.1",

Check notice

Code scanning / Tslint (reported by Codacy)

" should be ' Note

" should be '
samples/client/js/package.json
"webpack-cli": "^3.3.6"
"jest": "^29.7.0",
"webpack": "^5.96.1",
"webpack-cli": "^5.1.4"

Check notice

Code scanning / Tslint (reported by Codacy)

" should be ' Note

" should be '
samples/server/express/package.json
},
"dependencies": {
"@singleton-i18n/js-core-sdk-server": "file:../../../singleton-i18n-js-core-sdk-server-0.5.7.tgz",
"@singleton-i18n/js-core-sdk-server": "file:../../../singleton-i18n-js-core-sdk-server-0.5.8.tgz",

Check notice

Code scanning / Tslint (reported by Codacy)

" should be ' Note

" should be '
github-advanced-security[bot]
github-advanced-security bot found potential problems Nov 15, 2024
View reviewed changes
package.json
"axios": "^0.21.1",
"jest": "^24.5.0",
"ts-jest": "^24.0.0",
"jest": "^29.7.0",

Check notice

Code scanning / Tslint (reported by Codacy)

" should be ' Note

" should be '
package.json
"jest": "^24.5.0",
"ts-jest": "^24.0.0",
"jest": "^29.7.0",
"jest-environment-jsdom": "^28.1.3",

Check notice

Code scanning / Tslint (reported by Codacy)

" should be ' Note

" should be '
package.json
"ts-jest": "^24.0.0",
"jest": "^29.7.0",
"jest-environment-jsdom": "^28.1.3",
"ts-jest": "^29.2.5",

Check notice

Code scanning / Tslint (reported by Codacy)

" should be ' Note

" should be '
package.json
"typings": "^2.1.1",
"webpack": "^4.20.2",
"webpack-cli": "^3.3.0"
"webpack": "^5.96.1",

Check notice

Code scanning / Tslint (reported by Codacy)

" should be ' Note

" should be '
package.json
"webpack": "^4.20.2",
"webpack-cli": "^3.3.0"
"webpack": "^5.96.1",
"webpack-cli": "^5.1.4"

Check notice

Code scanning / Tslint (reported by Codacy)

" should be ' Note

" should be '
package.json
},
"changelogHistory": [
{
"date": "11/15/24",

Check notice

Code scanning / Tslint (reported by Codacy)

" should be ' Note

" should be '
samples/client/js/package.json
"webpack": "^5.96.1",
"webpack-cli": "^5.1.4"
},
"jest": {

Check notice

Code scanning / Tslint (reported by Codacy)

" should be ' Note

" should be '
samples/client/js/package.json
"webpack-cli": "^5.1.4"
},
"jest": {
"testEnvironment": "jsdom"

Check notice

Code scanning / Tslint (reported by Codacy)

" should be ' Note

" should be '
@sjiang-cb sjiang-cb enabled auto-merge November 15, 2024 05:22
@sjiang-cb sjiang-cb disabled auto-merge November 15, 2024 05:25
@sjiang-cb sjiang-cb enabled auto-merge November 15, 2024 05:28
@sjiang-cb sjiang-cb disabled auto-merge November 15, 2024 05:30
@sjiang-cb sjiang-cb merged commit 7061f16 into vmware:g11n-js-client Nov 15, 2024
18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jhua-vmware jhua-vmware jhua-vmware approved these changes

Assignees

No one assigned

Labels

cla-not-required

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@sjiang-cb @jhua-vmware @vmwclabot