Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[artifact-manager,vra-ng] (#207) Remove regional content support from vra-ng projects #452

Merged
merged 15 commits into from
Nov 1, 2024
Merged

[artifact-manager,vra-ng] (#207) Remove regional content support from vra-ng projects #452

merged 15 commits into from
Nov 1, 2024

Conversation

Michaelpalacce
Copy link
Collaborator

@Michaelpalacce Michaelpalacce commented Oct 11, 2024 •
edited by VenelinBakalov
Loading

Description

Checklist

  • I have added relevant error handling and logging messages to help troubleshooting
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation, relevant usage information (if applicable)
  • I have updated the PR title with affected component, related issue number and a short summary of the changes introduced
  • I have added labels for implementation kind (kind/) and version type (version/)
  • I have tested against live environment, if applicable
  • I have synced any structure and/or content vRA-NG improvements with vra-ng and ts-vra-ng archetypes (if applicable)
  • I have my changes rebased and squashed to the minimal number of relevant commits. Notice: don't squash all commits
  • I have added a descriptive commit message with a short title, including a Fixed #XXX - or Closed #XXX - prefix to auto-close the issue

Testing

Release Notes

Removed Regional Content from everywhere it was used

Related issues and PRs

#207

@Michaelpalacce
refactor!: Removed image-mappings from the code
46406ea 
- As a result of this the new structure needs to be built up from the
  ground up.
- Checklist:
- [ ] Pulling
- [ ] Pushing
- [ ] Deletion
Signed-off-by: Stefan Genov <[email protected]>
@Michaelpalacce
refactor!: Removed Regional resources
0e3f867 
Signed-off-by: Stefan Genov <[email protected]>
@github-actions github-actions bot added kind/feature New Feature to the project kind/refactor Refactoring of existing features labels Oct 11, 2024
@Michaelpalacce Michaelpalacce changed the title Feat/207 image mapping refactor [*] (#207) Removed Regional Content Oct 11, 2024
@Michaelpalacce Michaelpalacce added lang/java Related to Java Code area/artifact-manager Relates to the `artifact-manager` maven module version/major Introduces a breaking change area/maven Relates to maven changes java Pull requests that update Java code and removed kind/feature New Feature to the project labels Oct 11, 2024
@Michaelpalacce Michaelpalacce self-assigned this Oct 11, 2024
@github-actions github-actions bot added the kind/feature New Feature to the project label Oct 14, 2024
@Michaelpalacce
Merge branch 'main' of https://github.com/vmware/build-tools-for-vmwa…
a67c435 
…re-aria into feat/207-image-mapping-refactor

Signed-off-by: Stefan Genov <[email protected]>
@Michaelpalacce
refactor(lint): Removed unused import
c929c3b 
Signed-off-by: Stefan Genov <[email protected]>
@Michaelpalacce
docs: Removed Docs for regional content
80b1829 
Signed-off-by: Stefan Genov <[email protected]>
@Michaelpalacce
docs: Add Release notes
dcef6e4 
Signed-off-by: Stefan Genov <[email protected]>
@Michaelpalacce
style(lint): Removed empty space
9aa06c8 
Signed-off-by: Stefan Genov <[email protected]>
@Michaelpalacce
chore(build): Try to build with 16
2780738 
Signed-off-by: Stefan Genov <[email protected]>
@Michaelpalacce
Revert "chore(build): Try to build with 16"
748e4ed 
This reverts commit 2780738.

Signed-off-by: Stefan Genov <[email protected]>
@Michaelpalacce
fix: Using ubuntu-22 instead
67d8c5b 
- Ref: https://github.com/orgs/nodejs/discussions/43184
Signed-off-by: Stefan Genov <[email protected]>
@VenelinBakalov VenelinBakalov changed the title [*] (#207) Removed Regional Content [artifact-manager,vra-ng] (#207) Remove Regional Content Oct 14, 2024
@VenelinBakalov VenelinBakalov changed the title [artifact-manager,vra-ng] (#207) Remove Regional Content [artifact-manager,vra-ng] (#207) Remove regional content support from vra-ng projects Oct 14, 2024
@Michaelpalacce
Merge branch 'main' of https://github.com/vmware/build-tools-for-vmwa…
b609a21 
…re-aria into feat/207-image-mapping-refactor

Signed-off-by: Stefan Genov <[email protected]>
@github-actions github-actions bot added the kind/enhancement Enhancement or improvement of existing features label Oct 14, 2024
@Michaelpalacce Michaelpalacce marked this pull request as ready for review October 14, 2024 11:02
@Michaelpalacce Michaelpalacce requested a review from a team as a code owner October 14, 2024 11:02
@Michaelpalacce Michaelpalacce added this to the 3.0.0 milestone Oct 14, 2024
@Michaelpalacce
Merge branch 'main' of https://github.com/vmware/build-tools-for-vmwa…
4a80f89 
…re-aria into feat/207-image-mapping-refactor

Signed-off-by: Stefan Genov <[email protected]>
@VenelinBakalov VenelinBakalov removed the kind/feature New Feature to the project label Oct 14, 2024
@VenelinBakalov
Copy link
Collaborator

Do we need to update anything in the installer?

@Michaelpalacce Michaelpalacce removed this from the 3.0.0 milestone Oct 16, 2024
@VenelinBakalov VenelinBakalov modified the milestones: 3.0.0, BTVA Next Oct 25, 2024
@vmwclabot
Copy link
Member

@Michaelpalacce, you must sign every commit in this pull request acknowledging our Developer Certificate of Origin before your changes are merged. This can be done by adding Signed-off-by: John Doe <[email protected]> to the last line of each Git commit message. The e-mail address used to sign must match the e-mail address of the Git author. Click here to view the Developer Certificate of Origin agreement.

1 similar comment
@vmwclabot
Copy link
Member

@Michaelpalacce, you must sign every commit in this pull request acknowledging our Developer Certificate of Origin before your changes are merged. This can be done by adding Signed-off-by: John Doe <[email protected]> to the last line of each Git commit message. The e-mail address used to sign must match the e-mail address of the Git author. Click here to view the Developer Certificate of Origin agreement.

@github-actions github-actions bot added kind/enhancement Enhancement or improvement of existing features kind/feature New Feature to the project labels Oct 25, 2024
VenelinBakalov
VenelinBakalov requested changes Oct 25, 2024
View reviewed changes
Copy link
Collaborator

@VenelinBakalov VenelinBakalov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

just 1 minor comment left

@Michaelpalacce @VenelinBakalov
Update docs/versions/latest/Release.md
4589e6e 
Co-authored-by: Venelin Bakalov <[email protected]>
Signed-off-by: Stefan Genov <[email protected]>
@vmwclabot
Copy link
Member

@Michaelpalacce, you must sign every commit in this pull request acknowledging our Developer Certificate of Origin before your changes are merged. This can be done by adding Signed-off-by: John Doe <[email protected]> to the last line of each Git commit message. The e-mail address used to sign must match the e-mail address of the Git author. Click here to view the Developer Certificate of Origin agreement.

1 similar comment
@vmwclabot
Copy link
Member

@Michaelpalacce, you must sign every commit in this pull request acknowledging our Developer Certificate of Origin before your changes are merged. This can be done by adding Signed-off-by: John Doe <[email protected]> to the last line of each Git commit message. The e-mail address used to sign must match the e-mail address of the Git author. Click here to view the Developer Certificate of Origin agreement.

@Michaelpalacce
Copy link
Collaborator Author

@VenelinBakalov done! Syncing with main now if needed

@Michaelpalacce
Copy link
Collaborator Author

Turns out no need to sync

@Michaelpalacce Michaelpalacce merged commit a9fe913 into main Nov 1, 2024
11 checks passed
@VenelinBakalov VenelinBakalov modified the milestones: BTVA Next, 3.0.0 Nov 1, 2024
@Michaelpalacce Michaelpalacce removed this from the 3.0.0 milestone Nov 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@VenelinBakalov VenelinBakalov VenelinBakalov approved these changes

Assignees

@Michaelpalacce Michaelpalacce

Labels
area/artifact-manager Relates to the `artifact-manager` maven module area/maven Relates to maven changes kind/enhancement Enhancement or improvement of existing features kind/feature New Feature to the project kind/refactor Refactoring of existing features lang/java Related to Java Code version/major Introduces a breaking change
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Michaelpalacce @VenelinBakalov @vmwclabot