Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[vrotsc-types] (#347) Add remaining Aria plugin types definitions #413

Merged
merged 3 commits into from
Sep 12, 2024

Conversation

unbreakabl3
Copy link
Contributor

Description

Checklist

  • I have added relevant error handling and logging messages to help troubleshooting
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation, relevant usage information (if applicable)
  • I have updated the PR title with affected component, related issue number and a short summary of the changes introduced
  • I have added labels for implementation kind (kind/) and version type (version/)
  • I have tested against live environment, if applicable
  • I have synced any structure and/or content vRA-NG improvements with vra-ng and ts-vra-ng archetypes (if applicable)
  • I have my changes rebased and squashed to the minimal number of relevant commits. Notice: don't squash all commits
  • I have added a descriptive commit message with a short title, including a Fixed #XXX - or Closed #XXX - prefix to auto-close the issue

Testing

Release Notes

Related issues and PRs

#347

Signed-off-by: Leonid Belenkiy <[email protected]>
@unbreakabl3 unbreakabl3 requested a review from a team as a code owner September 11, 2024 08:19
@github-actions github-actions bot added the kind/bug Something isn't working label Sep 11, 2024
@unbreakabl3
Copy link
Contributor Author

Hi @VenelinBakalov ,
this is a last one. All classes were added.

@VenelinBakalov VenelinBakalov added kind/enhancement Enhancement or improvement of existing features area/vro-types Relates to changes to the type definitions version/patch The change is a non-breaking bugfix and removed kind/bug Something isn't working labels Sep 11, 2024
Signed-off-by: Leonid Belenkiy <[email protected]>
@github-actions github-actions bot added the kind/bug Something isn't working label Sep 11, 2024
Signed-off-by: Leonid Belenkiy <[email protected]>
@VenelinBakalov
Copy link
Collaborator

Hi @VenelinBakalov , this is a last one. All classes were added.

That's awesome! thank you so much for extending all of these, it is quite big effort!

@VenelinBakalov VenelinBakalov changed the title [vrotsc-types] (#347) Extend Aria plugin types definitions [vrotsc-types] (#347) Add remaining missing Aria plugin types definitions Sep 12, 2024
@VenelinBakalov VenelinBakalov changed the title [vrotsc-types] (#347) Add remaining missing Aria plugin types definitions [vrotsc-types] (#347) Add remaining Aria plugin types definitions Sep 12, 2024
@VenelinBakalov VenelinBakalov removed the kind/bug Something isn't working label Sep 12, 2024
@VenelinBakalov VenelinBakalov merged commit 44e0bf2 into vmware:main Sep 12, 2024
9 checks passed
@unbreakabl3 unbreakabl3 deleted the fix/347-add-missing-classes branch September 12, 2024 11:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/vro-types Relates to changes to the type definitions kind/enhancement Enhancement or improvement of existing features version/patch The change is a non-breaking bugfix
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants