[vrotsc] (#301) Improve error messages for Policy Template, Workflow and Configuration files with incorrect extensions #399
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Throw errors for files with .pl, .conf, .wf extensions (without .ts / .xml / .yaml) Includes fix for calling undefined function when extension is unsupported Signed-off-by: Mihail Penchev (c) <[email protected]>
Check action .ts files for Configuration, Workflow, PolicyTemplate decorators, throw respective error Signed-off-by: Mihail Penchev (c) <[email protected]>
Signed-off-by: Mihail Penchev (c) <[email protected]>
bcpmihail
added
kind/enhancement
…decorator Signed-off-by: Mihail Penchev (c) <[email protected]>
VenelinBakalov
added
version/patch
…o program.ts Validation moved to a new helper used in resource transformer Updated Release.md Signed-off-by: Mihail Penchev (c) <[email protected]>
VenelinBakalov
changed the title
VenelinBakalov
approved these changes
Aug 30, 2024
There was a problem hiding this comment.
LGTM
Maybe we should wait for @Michaelpalacce as well to approve as he requested the original change
VenelinBakalov
deleted the
feature/301-error-wrong-filename-with-decorator
branch
VenelinBakalov
removed
kind/feature
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Replaces the non-specific error of the type "SyntaxError: [9:15]: Unexpected token: '-'" thrown when a file has an unsupported extension (e.g. .wf):
in the cases when a .ts Action file contains a Workflow, Configuration or PolicyTemplate decorator:
in the cases when the file extension is .pl, .wf, .conf (omitted .ts/.xml/.yaml extension):
in the case of all other unsupported file extensions, the file is treated as Resource, retaining the existing behavior.
Checklist
Fixed #XXX -orClosed #XXX -prefix to auto-close the issueTesting
Tested manually on a new TS archetype project.
Related issues and PRs
Closes #301