-
Notifications
You must be signed in to change notification settings - Fork 21
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[vrotsc] (#340) Add Workflow canvas Workflow End item #348
Merged
Merged
Changes from 4 commits
Commits
Show all changes
8 commits
Select commit
Hold shift + click to select a range
40adf1a
[Task 340] Initial implementation of workflow end item.
akantchev 0f96880
[Task 340] docs: Updated md files.
akantchev fadec02
[Task 340] docs: Updated formatting.
akantchev 23cc51e
[Task 340] code: Added support for business status.
akantchev 9d6cf9a
[Task 340] code: Updated annotation variable name.
akantchev 3c61a76
[Task 340] code: Updated test workflows methods not to contain parame…
akantchev 3932ea3
[Task 340] code: Removed unused imports in test workflows.
akantchev 18c4e1c
[Task 340] docs: Updated examples, added parameter docs.
akantchev File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
34 changes: 34 additions & 0 deletions
34
typescript/vrotsc/e2e/cases/canvas-items/end-item-exception.wf.ts
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,34 @@ | ||
import { Workflow, In, Out, RootItem, WorkflowEndItem } from "vrotsc-annotations"; | ||
|
||
@Workflow({ | ||
name: "Workflow End Exception", | ||
path: "VMware/PSCoE", | ||
description: "Workflow with root and end item with end mode 1", | ||
attributes: { | ||
errorMessage: { | ||
type: "string" | ||
}, | ||
businessStatus: { | ||
type: "string" | ||
}, | ||
endMode: { | ||
type: "number" | ||
} | ||
} | ||
}) | ||
export class WorkflowEnd { | ||
|
||
@RootItem() | ||
public initiateWorkflow() { | ||
// NOOP | ||
} | ||
|
||
@WorkflowEndItem({ | ||
endMode: 1, | ||
exception: "errorMessage", | ||
businessStatus: "Bad" | ||
}) | ||
public workflowEnd(@In endMode: number, @Out errorMessage: string) { | ||
// NOOP | ||
} | ||
} |
26 changes: 26 additions & 0 deletions
26
typescript/vrotsc/e2e/cases/canvas-items/end-item-happy.wf.ts
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,26 @@ | ||
import { Workflow, In, Out, RootItem, WorkflowEndItem } from "vrotsc-annotations"; | ||
|
||
@Workflow({ | ||
name: "Workflow End Happy", | ||
path: "VMware/PSCoE", | ||
description: "Workflow with root and end item", | ||
attributes: { | ||
endMode: { | ||
type: "number" | ||
} | ||
} | ||
}) | ||
export class WorkflowEnd { | ||
|
||
@RootItem() | ||
public initiateWorkflow() { | ||
// NOOP | ||
} | ||
|
||
@WorkflowEndItem({ | ||
endMode: 0 | ||
}) | ||
public workflowEnd(@In endMode: number) { | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Same comment here There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. It is required by the XML representation of the component. |
||
// NOOP | ||
} | ||
} |
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why is endMode needed?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It is required by the XML representation of the component.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is an input parameter,
end-mode
is a property of the workflow item. It makes no sense to have it as an input tooThere was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code updated.