IAC-772 Fixed project IDs for resources #147
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Petar Penev <[email protected]> Signed-off-by: Petar Penev <[email protected]>
iludart
changed the title
Signed-off-by: Petar Penev <[email protected]> Signed-off-by: Petar Penev <[email protected]>
…re-aria into IAC-772 Signed-off-by: Petar Penev <[email protected]>
Michaelpalacce
requested changes
Jul 24, 2023
common/artifact-manager/src/main/java/com/vmware/pscoe/iac/artifact/utils/VraNgProjectUtil.java
Outdated
Show resolved
Hide resolved
...anager/src/main/java/com/vmware/pscoe/iac/artifact/store/vrang/VraNgCustomResourceStore.java
Outdated
Show resolved
Hide resolved
...anager/src/main/java/com/vmware/pscoe/iac/artifact/store/vrang/VraNgResourceActionStore.java
Outdated
Show resolved
Hide resolved
...artifact-manager/src/test/java/com/vmware/pscoe/iac/artifact/utils/VraNgProjectUtilTest.java
Outdated
Show resolved
Hide resolved
Signed-off-by: Petar Penev <[email protected]>
|
Well, VraNgCustomResourceStore and VraNgResourceActionStore don't actually hold any logic that is related to this. Currently there are tests that cover the innermost piece that handles project id for custom resources and resource actions so I don't think it is necessary to test if it is called or not (it is not conditional). |
Signed-off-by: Petar Penev <[email protected]>
Signed-off-by: Petar Penev <[email protected]>
Signed-off-by: Petar Penev <[email protected]>
|
@iludart makes sense to me :) |
Michaelpalacce
approved these changes
Jul 27, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
When pushing Resource Actions (RAs), the ones that are scoped to a single project now have their projectId modified to be the same as in the configuration.
Checklist
Fixed #XXX -orClosed #XXX -prefix to auto-close the issueTesting
Tested pushing Resource Actions to a vApp environment. Performed tests with resource actions scoped to a single project and they have their projectId modified. Also tested with global resource actions (without projectId) and those are not modified.
Related issues and PRs
https://jira.pscoe.vmware.com/browse/IAC-772