Skip to content

Commit

Permalink
chore: reverting temporary changes to sun_checks.yml, codeql-java.yml
Browse files Browse the repository at this point in the history
Signed-off-by: Mihail Penchev (c) <[email protected]>
  • Loading branch information
bcpmihail committed Sep 11, 2024
1 parent d7f3ff4 commit 3b3182f
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 30 deletions.
28 changes: 0 additions & 28 deletions .github/linters/sun_checks.xml
Original file line number Diff line number Diff line change
Expand Up @@ -64,9 +64,7 @@ https://www.oracle.com/java/technologies/javase/codeconventions-contents.html

<!-- Checks that a package-info.java file exists for each package. -->
<!-- See https://checkstyle.org/config_javadoc.html#JavadocPackage -->
<!--
<module name="JavadocPackage" />
-->

<!-- Checks whether files end with a new line. -->
<!-- See https://checkstyle.org/config_misc.html#NewlineAtEndOfFile -->
Expand Down Expand Up @@ -107,18 +105,15 @@ https://www.oracle.com/java/technologies/javase/codeconventions-contents.html

<!-- Checks for Javadoc comments. -->
<!-- See https://checkstyle.org/config_javadoc.html -->
<!--
<module name="InvalidJavadocPosition" />
<module name="JavadocMethod" />
<module name="JavadocType" />
<module name="JavadocVariable" />
<module name="JavadocStyle" />
<module name="MissingJavadocMethod" />
-->

<!-- Checks for Naming Conventions. -->
<!-- See https://checkstyle.org/config_naming.html -->
<!--
<module name="ConstantName" />
<module name="LocalFinalVariableName" />
<module name="LocalVariableName" />
Expand All @@ -132,69 +127,55 @@ https://www.oracle.com/java/technologies/javase/codeconventions-contents.html
<module name="StaticVariableName" />
<module name="TypeName" />

-->
<!-- Checks for imports -->
<!-- See https://checkstyle.org/config_imports.html -->
<!-- <module name="AvoidStarImport" /> -->
<module name="IllegalImport" /> <!-- defaults to sun.* packages -->
<!--
<module name="RedundantImport" />
<module name="UnusedImports">
<property name="processJavadoc" value="false" />
</module>
-->

<!-- Checks for Size Violations. -->
<!-- See https://checkstyle.org/config_sizes.html -->
<!--
<module name="MethodLength" />
<module name="ParameterNumber">
<property name="max" value="10" />
<property name="tokens" value="METHOD_DEF" />
</module>
-->

<!-- Checks for whitespace -->
<!-- See https://checkstyle.org/config_whitespace.html -->
<!--
<module name="EmptyForIteratorPad" />
<module name="GenericWhitespace" />
<module name="MethodParamPad" />
-->

<!-- Ignore '{' is followed by whitespace. [NoWhitespaceAfter] -->
<!-- <module name="NoWhitespaceAfter"/> -->
<!--
<module name="NoWhitespaceBefore" />
<module name="OperatorWrap" />
<module name="ParenPad" />
<module name="TypecastParenPad" />
<module name="WhitespaceAfter" />
<module name="WhitespaceAround" />
-->

<!-- Modifier Checks -->
<!-- See https://checkstyle.org/config_modifier.html -->
<!--
<module name="ModifierOrder" />
<module name="RedundantModifier" />
-->

<!-- Checks for blocks. You know, those {}'s -->
<!-- See https://checkstyle.org/config_blocks.html -->
<!--
<module name="AvoidNestedBlocks">
<property name="allowInSwitchCase" value="true"/>
</module>
<module name="EmptyBlock" />
<module name="LeftCurly" />
<module name="NeedBraces" />
<module name="RightCurly" />
-->

<!-- Checks for common coding problems -->
<!-- See https://checkstyle.org/config_coding.html -->
<!--
<module name="EmptyStatement" />
<module name="EqualsHashCode" />
<module name="HiddenField" >
Expand All @@ -208,40 +189,31 @@ https://www.oracle.com/java/technologies/javase/codeconventions-contents.html
<module name="MultipleVariableDeclarations" />
<module name="SimplifyBooleanExpression" />
<module name="SimplifyBooleanReturn" />
-->

<!-- Checks for class design -->
<!-- See https://checkstyle.org/config_design.html -->
<!--
<module name="DesignForExtension" />
<module name="FinalClass" />
<module name="HideUtilityClassConstructor" />
<module name="InterfaceIsType" />
<module name="VisibilityModifier" >
<property name="protectedAllowed" value="true"/>
</module>
-->

<!-- Miscellaneous other checks. -->
<!-- See https://checkstyle.org/config_misc.html -->
<!--
<module name="ArrayTypeStyle" />
-->
<!-- FinalParameters reports False positives -->
<!-- <module name="FinalParameters" /> -->
<!-- <module name="TodoComment" /> -->
<!--
<module name="UpperEll" />
-->

<!-- https://checkstyle.org/config_filters.html#SuppressionXpathFilter -->
<!--
<module name="SuppressionXpathFilter">
<property name="file" value="${org.checkstyle.sun.suppressionxpathfilter.config}"
default="checkstyle-xpath-suppressions.xml" />
<property name="optional" value="true" />
</module>
-->

</module>

Expand Down
4 changes: 2 additions & 2 deletions .github/workflows/codeql-java.yml
Original file line number Diff line number Diff line change
Expand Up @@ -67,5 +67,5 @@ jobs:
- name: Build 'typescript-project-all'
run: mvn -T 1C clean install -f maven/typescript-project-all/pom.xml -s $PWD/.m2/settings.xml

# - name: Perform CodeQL Analysis
# uses: github/codeql-action/analyze@v2
- name: Perform CodeQL Analysis
uses: github/codeql-action/analyze@v2

0 comments on commit 3b3182f

Please sign in to comment.