🌱 Update k8s.io/code-generator to 0.30.1 #547
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This patch updates k8s.io/code-generator to 0.30.1 following the resolution of the missing "--input-dirs" flag problem in the issue kubernetes/code-generator#172.
|
dilyar85
approved these changes
May 31, 2024
There was a problem hiding this comment.
Verified the new package version and args work for my darwin_amd64 machine locally:
sdiliyaer in ~/vm-operator on git:akutz/feature/code-gen-0.30.1 ✔︎ 33bb7032 "Update k8s.io/code-generator to 0.30.1"
10:54:54 $ make generate-go-conversions
NEW_GOPATH="$(mktemp -d)" && \
NEW_ROOT_DIR="${NEW_GOPATH}/src/github.com/vmware-tanzu/vm-operator" && \
mkdir -p "${NEW_ROOT_DIR}" && \
rm -fr "${NEW_ROOT_DIR}" && \
ln -s "/Users/sdiliyaer/vm-operator/" "${NEW_ROOT_DIR}" && \
cd "${NEW_ROOT_DIR}" && \
GOPATH="${NEW_GOPATH}" ROOT_DIR="${NEW_ROOT_DIR}" make generate-go-conversions
cd api && \
/Users/sdiliyaer/vm-operator/hack/tools/bin/darwin_amd64/conversion-gen \
--output-file=zz_generated.conversion.go \
--go-header-file=/Users/sdiliyaer/vm-operator/hack/boilerplate/boilerplate.generatego.txt \
--extra-peer-dirs='./v1alpha2/sysprep/conversion/v1alpha2,./v1alpha2/sysprep/conversion/v1alpha3' \
./v1alpha1 ./v1alpha2
W0531 10:55:21.261132 45498 parse.go:769] Making unsupported type entry "T" for: &types.TypeParam{check:(*types.Checker)(nil), id:0x1, obj:(*types.TypeName)(0xc04962e410), index:0, bound:(*types.Interface)(0xc000180af0)}
sdiliyaer in ~/vm-operator on git:akutz/feature/code-gen-0.30.1 ✔︎ 33bb7032 "Update k8s.io/code-generator to 0.30.1"
10:56:10 $ echo $?
0
|
Thank you @dilyar85 for verifying it locally! And thanks for fixing the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do, and why is it needed?
This patch updates k8s.io/code-generator to 0.30.1 following the resolution of the missing "--input-dirs" flag problem in the issue kubernetes/code-generator#172.
Which issue(s) is/are addressed by this PR? (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)format, will close the issue(s) when PR gets merged):Fixes
NAAre there any special notes for your reviewer:
Please add a release note if necessary: